From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: dom0 kenrel crashes for openstack + libvirt + libxl
Date: Fri, 21 Nov 2014 09:28:46 +0000
Message-ID: <1416562126.26869.8.camel@citrix.com>
References: <CA+J9cpa8bR0v9Po1ZmTiPbdat7XbmiVYyg0ALPq+gtHxf3WGeA@mail.gmail.com>
	<54648EB3.8040703@citrix.com>
	<CA+J9cpZqVa4mfCQzHPTLVoMCCFeNJQ+M_HwY4-2zhBQMYzHK2g@mail.gmail.com>
	<1415955718.31613.34.camel@citrix.com>
	<CA+J9cpbcJETKqAkr0pqo_bjR8+Sr33YS0+PK85UZ+TowfkWtTw@mail.gmail.com>
	<1416227964.5466.12.camel@citrix.com>
	<CA+J9cpZP_GUCtXJVZGL0M94UCVCygPxcsZGpT4_rSPrQbvfz5w@mail.gmail.com>
	<1416475824.14429.1.camel@citrix.com>
	<CA+J9cpam6taP+V9Eh7ifmC5S29uXgRaehLcuPW6NVC5-MsnTKA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CA+J9cpam6taP+V9Eh7ifmC5S29uXgRaehLcuPW6NVC5-MsnTKA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Xing Lin <linxingnku@gmail.com>, Jim Fehlig <jfehlig@suse.com>
Cc: xen-devel@lists.xen.org, Roger Pau =?ISO-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-11-20 at 16:53 -0700, Xing Lin wrote:

> I git clone nova-juno from github and searched for 'pygrub'. Here is what i get. 
> 
> 
> .//etc/nova/rootwrap.d/compute.filters:104:# nova/virt/xenapi/vm_utils.py: 'pygrub', '-qn', dev_path
> .//etc/nova/rootwrap.d/compute.filters:105:pygrub: CommandFilter, pygrub, root
> .//nova/tests/unit/virt/xenapi/test_xenapi.py:667:        self.assertEqual(self.vm['PV_bootloader'], 'pygrub')
> .//nova/virt/xenapi/vm_utils.py:298:            rec['PV_bootloader'] = 'pygrub'
> 
> 
> It seems that nova does not specify absolute path for pygrub. 
> 
> 
> I checked libvirt source code and found the following definition.
> 
> 
> .//src/libxl/libxl_conf.h:52:# define LIBXL_BOOTLOADER_PATH BINDIR "/pygrub"

Thanks for investigating.

I think libvirt is wrong to specify an absolute path here, IMHO by
default it should just specify "pygrub" and let libxl figure out the
correct path. Jim, what do you think?

Ian.