From: Chris Mason <clm@fb.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Sabrina Dubroca <sd@queasysnail.net>,
David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 net] net: Revert "net: avoid one atomic operation in skb_clone()"
Date: Fri, 21 Nov 2014 16:15:56 -0500 [thread overview]
Message-ID: <1416604556.24312.11@mail.thefacebook.com> (raw)
In-Reply-To: <1416599236.8629.124.camel@edumazet-glaptop2.roam.corp.google.com>
On Fri, Nov 21, 2014 at 2:47 PM, Eric Dumazet <eric.dumazet@gmail.com>
wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> v2: the revert went wrong, as SKB_FCLONE_UNAVAILABLE
> was later replaced by SKB_FCLONE_FREE, spotted by Sabrina Dubroca
>
v2 is happy here too. I'll let it keep going over the weekend and add
more memory pressure, but my crashes seem to be gone.
-chris
next prev parent reply other threads:[~2014-11-21 21:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 16:16 crash in __kfree_skb on v3.18-rc5 with CONFIG_DEBUG_PAGEALLOC Chris Mason
2014-11-21 16:31 ` Eric Dumazet
2014-11-21 16:37 ` Eric Dumazet
2014-11-21 16:47 ` Chris Mason
2014-11-21 16:56 ` Eric Dumazet
2014-11-21 17:18 ` Chris Mason
2014-11-21 16:41 ` Chris Mason
2014-11-21 16:57 ` Chris Mason
2014-11-21 17:04 ` [PATCH net] net: Revert "net: avoid one atomic operation in skb_clone()" Eric Dumazet
2014-11-21 18:05 ` Sabrina Dubroca
2014-11-21 19:29 ` Eric Dumazet
2014-11-21 19:39 ` Chris Mason
2014-11-21 19:47 ` [PATCH v2 " Eric Dumazet
2014-11-21 20:27 ` David Miller
2014-11-21 21:15 ` Chris Mason [this message]
2014-11-21 16:33 ` crash in __kfree_skb on v3.18-rc5 with CONFIG_DEBUG_PAGEALLOC Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416604556.24312.11@mail.thefacebook.com \
--to=clm@fb.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.