From: Peter Wu <lekensteyn@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org,
Manoj Chourasia <mchourasia@nvidia.com>,
linux-kernel@vger.kernel.org, alnovak@suse.cz
Subject: Re: List corruption in hidraw_release in 3.11-rc4
Date: Thu, 08 Aug 2013 00:28:45 +0200 [thread overview]
Message-ID: <1416898.RFahovXudQ@al> (raw)
In-Reply-To: <alpine.LNX.2.00.1308071533130.10425@pobox.suse.cz>
On Wednesday 07 August 2013 15:34:08 Jiri Kosina wrote:
> On Wed, 7 Aug 2013, Peter Wu wrote:
> > [..]
> > I have applied Manoj's patch[1] on top of 3.11-rc4 which seem to fix the
> > issue. One observation is that the new device is named /dev/hidraw1
> > instead of /dev/hidraw0. Example:
> >
> > f(){ hidraw-test /dev/hidraw$1 usb1;}
> > # needed for 3.11-rc4
> > f 1; f 1 # crash
> > # needed for 3.11-rc4 + patch
> > f 1; f 2 # ok
> >
> > Regards,
> > Peter
> >
> > [1]: http://lkml.org/lkml/2013/7/22/248
>
> That one I am still reviewing ... can I add your Tested-by: to it when
> I'll be applying it and pushing to Linus?
Sure, once you accept it you can add:
Tested-by: Peter Wu <lekensteyn@gmail.com>
While you are at it, are the other functions also safe? (i.e. hidraw_poll,
that one is not protected by any locks?)
Regards,
Peter
prev parent reply other threads:[~2013-08-07 22:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 21:30 List corruption in hidraw_release in 3.11-rc4 Peter Wu
2013-08-06 21:30 ` Peter Wu
2013-08-07 1:01 ` Jiri Kosina
2013-08-07 13:30 ` Peter Wu
2013-08-07 13:34 ` Jiri Kosina
2013-08-07 15:06 ` Manoj Chourasia
2013-08-07 22:28 ` Peter Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416898.RFahovXudQ@al \
--to=lekensteyn@gmail.com \
--cc=alnovak@suse.cz \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchourasia@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.