From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH for-xen-4.5] libxl: Allow copying smaller bitmap into a larger one Date: Tue, 25 Nov 2014 10:42:58 +0100 Message-ID: <1416908578.7176.10.camel@Abyss> References: <1416518854-5284-1-git-send-email-boris.ostrovsky@oracle.com> <20141124104127.GF30053@zion.uk.xensource.com> <20141124104703.GH30053@zion.uk.xensource.com> <54735343.1020208@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8492256452538998915==" Return-path: In-Reply-To: <54735343.1020208@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: Wei Liu , ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============8492256452538998915== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-/8PzkvCqfQoiepgJdr96" --=-/8PzkvCqfQoiepgJdr96 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2014-11-24 at 10:48 -0500, Boris Ostrovsky wrote: > On 11/24/2014 05:47 AM, Wei Liu wrote: > >> > >> The partial copy function should explicitly zero-out all remaining bit= s. >=20 > I actually thought that partial copy function should do just that ---=20 > copy bits that it has and leave others unchanged. The caller, if desires= =20 > so, should have cleared the mask prior to the call. (This is for the=20 > case when destination is larger than source, of course). >=20 Agreed. Anyway, AFAIU Wei's proposal, he's saying that this new _copy_partial() function can be an internal one, i.e., not part of the public API, or am I wrong, Wei? If yes, I agree with that. This leaves the question of whether we should change the behavior of the publicly exposed libxl_bitmap_copy(), which I'm still not sure about, but I guess, if we keep this internal, we can defer thinking to that to some other period not in between RCs? Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-/8PzkvCqfQoiepgJdr96 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlR0TyIACgkQk4XaBE3IOsQBVQCfYGoymOlKysPsrFnzqqv7qvUY xWYAniIf9JJYeGmEGwgBi8FtaaknUg8L =x9hZ -----END PGP SIGNATURE----- --=-/8PzkvCqfQoiepgJdr96-- --===============8492256452538998915== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8492256452538998915==--