From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [libvirt] [PATCH 1/2] virdbus: don't force users to
 pass int for bool values
Date: Tue, 25 Nov 2014 09:51:32 +0000
Message-ID: <1416909092.32327.3.camel@citrix.com>
References: <20141120101240.2a75f384@m> <546E7674.1060204@redhat.com>
	<546FD5D2.60400@redhat.com> <1416822231.26329.19.camel@citrix.com>
	<54735AF7.2060103@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54735AF7.2060103@redhat.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Eric Blake <eblake@redhat.com>
Cc: libvir-list@redhat.com, Ian Jackson <Ian.Jackson@eu.citrix.com>, cemeyer@uw.edu, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2014-11-24 at 09:21 -0700, Eric Blake wrote:
> On 11/24/2014 02:43 AM, Ian Campbell wrote:
> 
> >>>>
> >>>> I think this change breaks build on FreeBSD:
> >>>>
> >>>>   CC       util/libvirt_util_la-virdbus.lo
> >>>> util/virdbus.c:956:13: error: cast from 'bool *' to 'dbus_bool_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]
> >>>>             GET_NEXT_VAL(dbus_bool_t, bool_val, bool, "%d");
> >>>>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>>> util/virdbus.c:858:17: note: expanded from macro 'GET_NEXT_VAL'
> >>>>             x = (dbustype *)(*xptrptr + (*narrayptr - 1));              \
> >>>>                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.
> >>>
> >>> Valid complaint, so I'll have to figure something out to avoid it.  :(
> 
> > I'm, guessing that this is the same underlying issue as:
> >         util/virdbus.c: In function 'virDBusMessageIterDecode':
> >         util/virdbus.c:956:346: error: cast increases required alignment of target type [-Werror=cast-align]
> 
> Yes.
> 
> >         
> > which we are seeing in the Xen automated tests [0, 1] (on armhf only,
> > probably compiler dependent?).
> 
> So, do I have an ACK on my proposed fix yet? :)
> https://www.redhat.com/archives/libvir-list/2014-November/msg00838.html

Well, FWIW it looks good to me:

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Ian.