All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
	Namhyung Kim <namhyung.kim@lge.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 06/12] perf tools: Fix segfault due to invalid kernel dso access
Date: Tue, 25 Nov 2014 10:22:04 -0300	[thread overview]
Message-ID: <1416921730-5063-7-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1416921730-5063-1-git-send-email-acme@kernel.org>

From: Namhyung Kim <namhyung@kernel.org>

Jiri reported that the commit 96d78059d6d9 ("perf tools: Make vmlinux
short name more like kallsyms short name") segfaults on perf script.

When processing kernel mmap event, it should access the 'kernel'
variable as sometimes it cannot find a matching dso from build-id table
so 'dso' might be invalid.

Reported-by: Jiri Olsa <jolsa@redhat.com>
Tested-by: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1416285028-30572-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/machine.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index d97309c87bd6..b75b487574c7 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -1106,8 +1106,8 @@ static int machine__process_kernel_mmap_event(struct machine *machine,
 		if (__machine__create_kernel_maps(machine, kernel) < 0)
 			goto out_problem;
 
-		if (strstr(dso->long_name, "vmlinux"))
-			dso__set_short_name(dso, "[kernel.vmlinux]", false);
+		if (strstr(kernel->long_name, "vmlinux"))
+			dso__set_short_name(kernel, "[kernel.vmlinux]", false);
 
 		machine__set_kernel_mmap_len(machine, event);
 
-- 
1.9.3


  parent reply	other threads:[~2014-11-25 13:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 13:21 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
2014-11-25 13:21 ` [PATCH 01/12] perf hists browser: Print overhead percent value for first-level callchain Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 02/12] perf tools: Collapse first level callchain entry if it has sibling Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 03/12] perf callchain: Enable printing the srcline in the history Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 04/12] perf symbols: Move bfd_demangle stubbing to its only user Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 05/12] perf callchain: Make get_srcline fall back to sym+offset Arnaldo Carvalho de Melo
2014-11-25 13:22 ` Arnaldo Carvalho de Melo [this message]
2014-11-25 13:22 ` [PATCH 07/12] perf tools: Allow to force redirect pr_debug to stderr Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 08/12] perf evsel: Introduce perf_evsel__compute_deltas function Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 09/12] perf evsel: Introduce perf_counts_values__scale function Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 10/12] perf evsel: Introduce perf_evsel__read_cb function Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 11/12] perf tools: Add per-pkg format file parsing Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 12/12] perf tools: Add snapshot " Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416921730-5063-7-git-send-email-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.