From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for 4.5] xl: Return proper error codes for block-attach and block-detach Date: Tue, 25 Nov 2014 14:55:58 +0000 Message-ID: <1416927358.32327.37.camel@citrix.com> References: <1415813493-25330-1-git-send-email-george.dunlap@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Ian Jackson , Wei Liu , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Thu, 2014-11-20 at 16:06 +0000, George Dunlap wrote: > On Wed, Nov 12, 2014 at 5:31 PM, George Dunlap > wrote: > > Return proper error codes on failure so that scripts can tell whether > > the command completed properly or not. > > How about changing this to something like: > > --- > Return proper error codes on failure so that scripts can tell whether > the command completed properly or not. > > This is not a proper fix, since it fails to call > libxl_device_disk_dispose() on the error path. But a proper fix > requires some refactoring, so given where we are in the release > process, it's better to have a fix that is simple and obvious, and do > the refactoring once the next development window opens up. > > Signed-off-by: George Dunlap Looks good, I kept the single line title the same and replaced the body with the above, which I think is what you intended. Konrad acked taking this patch for 4.5 in a reply to v2, so I have pushed. Ian.