From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] missing chunk of HVM direct kernel boot patch Date: Fri, 28 Nov 2014 12:01:23 +0000 Message-ID: <1417176083.23604.20.camel@citrix.com> References: <1417154122-23669-1-git-send-email-cyliu@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1417154122-23669-1-git-send-email-cyliu@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chunyan Liu , Konrad Rzeszutek Wilk Cc: stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2014-11-28 at 13:55 +0800, Chunyan Liu wrote: > Found by Stefano, this chunk of the patch was never applied to > xen-unstable (commit 11dffa2359e8a2629490c14c029c7c7c777b3e47), > see http://marc.info/?l=qemu-devel&m=140471493425353&w=2. How strange, "git am" usually makes it pretty difficult to miss hunks. Sorry about this. > Signed-off-by: Chunyan Liu Acked-by: Ian Campbell I'm afraid that despite the circumstances this still needs a release ack from Konrad. Obviously the upside is fixing a partially implemented feature, but I'm not sure what the downsides are. Has this been tested with stubdoms, including when this feature is not used? My biggest concern is that because this function is also used to build the command line for the stubdom and the stubdom is PV and hence has at least a ->kernel setting then this new code might break that use case, by adding these options when they are not wanted. This path is all a bit tangled so I'm not 100% sure if those fields are actually set or not. > --- > tools/libxl/libxl_dm.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index 3e191c3..b25b574 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -527,6 +527,15 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc, > if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) { > int ioemu_nics = 0; > > + if (b_info->kernel) > + flexarray_vappend(dm_args, "-kernel", b_info->kernel, NULL); > + > + if (b_info->ramdisk) > + flexarray_vappend(dm_args, "-initrd", b_info->ramdisk, NULL); > + > + if (b_info->cmdline) > + flexarray_vappend(dm_args, "-append", b_info->cmdline, NULL); > + > if (b_info->u.hvm.serial || b_info->u.hvm.serial_list) { > if ( b_info->u.hvm.serial && b_info->u.hvm.serial_list ) > {