All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: use enum names instead of magic numbers
Date: Sat, 29 Nov 2014 20:57:21 -0800	[thread overview]
Message-ID: <1417323441.818.4.camel@perches.com> (raw)
In-Reply-To: <547AA272.6070308@sakamocchi.jp>

On Sun, 2014-11-30 at 13:52 +0900, Takashi Sakamoto wrote:
> On 2014年11月30日 05:58, Joe Perches wrote:
> > There's an enum defined for these magic numbers,
> > might as well use it.
[]
> I think it better to split this patch into two parts, one is for
> enumeration identifier and another is for variadic macro.

Go ahead then.

  reply	other threads:[~2014-11-30  4:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28 18:59 [PATCH] Sound: drivers: virmidi: fixed code style issues Kyle Chamberlin
2014-11-29 20:36 ` Takashi Iwai
2014-11-29 20:36   ` Takashi Iwai
2014-11-29 20:58   ` [PATCH] sound: use enum names instead of magic numbers Joe Perches
2014-11-30  4:52     ` Takashi Sakamoto
2014-11-30  4:52       ` Takashi Sakamoto
2014-11-30  4:57       ` Joe Perches [this message]
2014-11-30  8:41     ` Takashi Iwai
2014-11-30  8:55       ` Joe Perches
2014-11-30  9:04         ` Takashi Iwai
2014-11-30 19:26           ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417323441.818.4.camel@perches.com \
    --to=joe@perches.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o-takashi@sakamocchi.jp \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.