All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 0/2] xfs: more return cleanups
Date: Mon,  1 Dec 2014 15:20:06 +1100	[thread overview]
Message-ID: <1417407608-8016-1-git-send-email-david@fromorbit.com> (raw)

Hi folks,

I noticed a bit of inconsistency when reviewing the shift extent
return cleanups that coccinelle flagged. The first was that the
out_error labels were basically meaningless - it jsut returns the
error, and we have much neater ways of doing that. Also, the logic
flow through xfs_bmse_shift_one() jumped around all over the place -
it can be done lots neater without any gotos at all, and is easier
to read as a result.

These patches apply on top of the for-next branch (the
xfs-coccinelle-cleanups branch to be precise).

Cheers,

Dave.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2014-12-01  4:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01  4:20 Dave Chinner [this message]
2014-12-01  4:20 ` [PATCH 1/2] xfs: cleanup xfs_bmse_shift_one goto mess Dave Chinner
2014-12-01 16:41   ` Brian Foster
2014-12-01  4:20 ` [PATCH 2/2] xfs: cleanup xfs_bmse_merge returns Dave Chinner
2014-12-01 16:41   ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417407608-8016-1-git-send-email-david@fromorbit.com \
    --to=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.