All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tiejun Chen <tiejun.chen@intel.com>
To: jbeulich@suse.com, ian.jackson@eu.citrix.com,
	stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com,
	wei.liu2@citrix.com, kevin.tian@intel.com, tim@xen.org,
	yang.z.zhang@intel.com
Cc: xen-devel@lists.xen.org
Subject: [v8][PATCH 11/17] xen/x86/p2m: reject populating for reserved device memory mapping
Date: Mon,  1 Dec 2014 17:24:29 +0800	[thread overview]
Message-ID: <1417425875-9634-12-git-send-email-tiejun.chen@intel.com> (raw)
In-Reply-To: <1417425875-9634-1-git-send-email-tiejun.chen@intel.com>

We need to reject to populate reserved device memory mapping, and
then make sure all reserved device memory can't be accessed by any
!iommu approach.

Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
---
 xen/arch/x86/mm/p2m.c     | 59 +++++++++++++++++++++++++++++++++++++++++++++--
 xen/include/asm-x86/p2m.h |  9 ++++++++
 2 files changed, 66 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
index efa49dd..607ecd0 100644
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -556,6 +556,40 @@ guest_physmap_remove_page(struct domain *d, unsigned long gfn,
     gfn_unlock(p2m, gfn, page_order);
 }
 
+/* Check if we are accessing rdm. */
+int p2m_check_reserved_device_memory(xen_pfn_t start, xen_ulong_t nr,
+                                     u32 id, void *ctxt)
+{
+    xen_pfn_t end = start + nr;
+    unsigned int i;
+    u32 sbdf;
+    struct p2m_get_reserved_device_memory *pgrdm = ctxt;
+    struct domain *d = pgrdm->domain;
+
+    if ( d->arch.hvm_domain.pci_force )
+    {
+        if ( pgrdm->gfn >= start && pgrdm->gfn < end )
+            return 1;
+    }
+    else
+    {
+        for ( i = 0; i < d->arch.hvm_domain.num_pcidevs; i++ )
+        {
+            sbdf = PCI_SBDF2(d->arch.hvm_domain.pcidevs[i].seg,
+                             d->arch.hvm_domain.pcidevs[i].bus,
+                             d->arch.hvm_domain.pcidevs[i].devfn);
+
+            if ( sbdf == id )
+            {
+                if ( pgrdm->gfn >= start && pgrdm->gfn < end )
+                    return 1;
+            }
+        }
+    }
+
+    return 0;
+}
+
 int
 guest_physmap_add_entry(struct domain *d, unsigned long gfn,
                         unsigned long mfn, unsigned int page_order, 
@@ -568,6 +602,7 @@ guest_physmap_add_entry(struct domain *d, unsigned long gfn,
     mfn_t omfn;
     int pod_count = 0;
     int rc = 0;
+    struct p2m_get_reserved_device_memory pgrdm;
 
     if ( !paging_mode_translate(d) )
     {
@@ -686,8 +721,28 @@ guest_physmap_add_entry(struct domain *d, unsigned long gfn,
     /* Now, actually do the two-way mapping */
     if ( mfn_valid(_mfn(mfn)) ) 
     {
-        rc = p2m_set_entry(p2m, gfn, _mfn(mfn), page_order, t,
-                           p2m->default_access);
+        pgrdm.gfn = gfn;
+        pgrdm.domain = d;
+        if ( !is_hardware_domain(d) && iommu_use_hap_pt(d) )
+        {
+            rc = iommu_get_reserved_device_memory(p2m_check_reserved_device_memory,
+                                                  &pgrdm);
+            /* We always avoid populating reserved device memory. */
+            if ( rc == 1 )
+            {
+                rc = -EBUSY;
+                goto out;
+            }
+            else if ( rc < 0 )
+            {
+                printk(XENLOG_G_WARNING
+                       "Can't check reserved device memory for Dom%d.\n",
+                       d->domain_id);
+                goto out;
+            }
+        }
+
+        rc = p2m_set_entry(p2m, gfn, _mfn(mfn), page_order, t, p2m->default_access);
         if ( rc )
             goto out; /* Failed to update p2m, bail without updating m2p. */
 
diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h
index 5f7fe71..99f7fb7 100644
--- a/xen/include/asm-x86/p2m.h
+++ b/xen/include/asm-x86/p2m.h
@@ -709,6 +709,15 @@ static inline unsigned int p2m_get_iommu_flags(p2m_type_t p2mt)
     return flags;
 }
 
+struct p2m_get_reserved_device_memory {
+    unsigned long gfn;
+    struct domain *domain;
+};
+
+/* Check if we are accessing rdm. */
+extern int p2m_check_reserved_device_memory(xen_pfn_t start, xen_ulong_t nr,
+                                            u32 id, void *ctxt);
+
 #endif /* _XEN_P2M_H */
 
 /*
-- 
1.9.1

  parent reply	other threads:[~2014-12-01  9:24 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01  9:24 [v8][PATCH 00/17] xen: RMRR fix Tiejun Chen
2014-12-01  9:24 ` [v8][PATCH 01/17] tools/hvmloader: link errno.h from xen internal Tiejun Chen
2014-12-01  9:24 ` [v8][PATCH 02/17] introduce XEN_DOMCTL_set_rdm Tiejun Chen
2014-12-02  8:33   ` Tian, Kevin
2014-12-08  1:30     ` Chen, Tiejun
2014-12-02 19:39   ` Konrad Rzeszutek Wilk
2014-12-08  3:16     ` Chen, Tiejun
2014-12-08 15:57       ` Konrad Rzeszutek Wilk
2014-12-09  1:06         ` Chen, Tiejun
2014-12-09  8:33           ` Jan Beulich
2014-12-09 16:36             ` Konrad Rzeszutek Wilk
2014-12-04 15:33   ` Jan Beulich
2014-12-05  6:13     ` Tian, Kevin
2014-12-08  6:06     ` Chen, Tiejun
2014-12-08  8:43       ` Jan Beulich
2014-12-09  2:38         ` Chen, Tiejun
2014-12-09  7:29           ` Jan Beulich
2014-12-01  9:24 ` [v8][PATCH 03/17] introduce XENMEM_reserved_device_memory_map Tiejun Chen
2014-12-02 19:47   ` Konrad Rzeszutek Wilk
2014-12-08  6:17     ` Chen, Tiejun
2014-12-08 10:00       ` Jan Beulich
2014-12-08 16:45         ` Daniel De Graaf
2014-12-08 16:54           ` Jan Beulich
2014-12-01  9:24 ` [v8][PATCH 04/17] update the existing hypercall to support XEN_DOMCTL_set_rdm Tiejun Chen
2014-12-02  8:46   ` Tian, Kevin
2014-12-08  6:22     ` Chen, Tiejun
2014-12-04 15:50   ` Jan Beulich
2014-12-08  7:11     ` Chen, Tiejun
2014-12-08  8:51       ` Jan Beulich
2014-12-09  7:47         ` Chen, Tiejun
2014-12-09  8:19           ` Jan Beulich
2014-12-09  9:12             ` Chen, Tiejun
2014-12-09  9:21               ` Jan Beulich
2014-12-09  9:35                 ` Chen, Tiejun
2014-12-09 10:11             ` Tim Deegan
2014-12-09 10:22               ` Jan Beulich
2014-12-10  1:59                 ` Chen, Tiejun
2014-12-10 20:21                   ` Konrad Rzeszutek Wilk
2014-12-10  3:39               ` Tian, Kevin
2014-12-10  9:01                 ` Jan Beulich
2014-12-10  9:57                   ` Tian, Kevin
2014-12-10 11:12                 ` Tim Deegan
2014-12-11  2:03                   ` Tian, Kevin
2014-12-11 13:09                     ` Tim Deegan
2014-12-18 16:13                       ` Tim Deegan
2014-12-19  1:03                         ` Chen, Tiejun
2014-12-01  9:24 ` [v8][PATCH 05/17] tools/libxc: introduce hypercall for xc_reserved_device_memory_map Tiejun Chen
2014-12-02  8:46   ` Tian, Kevin
2014-12-02 19:50   ` Konrad Rzeszutek Wilk
2014-12-08  7:25     ` Chen, Tiejun
2014-12-08 15:52       ` Konrad Rzeszutek Wilk
2014-12-01  9:24 ` [v8][PATCH 06/17] tools/libxc: check if modules space is overlapping with reserved device memory Tiejun Chen
2014-12-02  8:54   ` Tian, Kevin
2014-12-02 19:55   ` Konrad Rzeszutek Wilk
2014-12-08  7:49     ` Chen, Tiejun
2014-12-01  9:24 ` [v8][PATCH 07/17] hvmloader/util: get reserved device memory maps Tiejun Chen
2014-12-02  8:59   ` Tian, Kevin
2014-12-08  7:55     ` Chen, Tiejun
2014-12-02 20:01   ` Konrad Rzeszutek Wilk
2014-12-08  8:09     ` Chen, Tiejun
2014-12-08  8:45       ` Chen, Tiejun
2014-12-04 15:52   ` Jan Beulich
2014-12-08  8:52     ` Chen, Tiejun
2014-12-08  9:18       ` Jan Beulich
2014-12-01  9:24 ` [v8][PATCH 08/17] hvmloader/mmio: reconcile guest mmio with reserved device memory Tiejun Chen
2014-12-02  9:11   ` Tian, Kevin
2014-12-08  9:04     ` Chen, Tiejun
2014-12-04 16:04   ` Jan Beulich
2014-12-08  9:10     ` Chen, Tiejun
2014-12-01  9:24 ` [v8][PATCH 09/17] hvmloader/ram: check if guest memory is out of reserved device memory maps Tiejun Chen
2014-12-02  9:42   ` Tian, Kevin
2014-12-02 20:17   ` Konrad Rzeszutek Wilk
2014-12-04 16:20   ` Jan Beulich
2014-12-05  6:23     ` Tian, Kevin
2014-12-05  7:43       ` Jan Beulich
2014-12-01  9:24 ` [v8][PATCH 10/17] hvmloader/mem_hole_alloc: skip any overlap with reserved device memory Tiejun Chen
2014-12-02  9:48   ` Tian, Kevin
2014-12-02 20:23   ` Konrad Rzeszutek Wilk
2014-12-04 16:28   ` Jan Beulich
2014-12-05  6:24     ` Tian, Kevin
2014-12-05  7:46       ` Jan Beulich
2014-12-01  9:24 ` Tiejun Chen [this message]
2014-12-02  9:57   ` [v8][PATCH 11/17] xen/x86/p2m: reject populating for reserved device memory mapping Tian, Kevin
2014-12-04 16:42   ` Jan Beulich
2014-12-01  9:24 ` [v8][PATCH 12/17] xen/x86/ept: handle reserved device memory in ept_handle_violation Tiejun Chen
2014-12-02  9:59   ` Tian, Kevin
2014-12-02 20:26   ` Konrad Rzeszutek Wilk
2014-12-04 16:46   ` Jan Beulich
2014-12-01  9:24 ` [v8][PATCH 13/17] xen/mem_access: don't allow accessing reserved device memory Tiejun Chen
2014-12-02 14:54   ` Julien Grall
2014-12-18 22:56     ` Tamas K Lengyel
2014-12-02 20:27   ` Konrad Rzeszutek Wilk
2014-12-04 16:51   ` Jan Beulich
2014-12-01  9:24 ` [v8][PATCH 14/17] xen/x86/p2m: introduce set_identity_p2m_entry Tiejun Chen
2014-12-02 10:00   ` Tian, Kevin
2014-12-02 20:29   ` Konrad Rzeszutek Wilk
2014-12-01  9:24 ` [v8][PATCH 15/17] xen:vtd: create RMRR mapping Tiejun Chen
2014-12-02 10:02   ` Tian, Kevin
2014-12-02 20:30   ` Konrad Rzeszutek Wilk
2014-12-01  9:24 ` [v8][PATCH 16/17] xen/vtd: group assigned device with RMRR Tiejun Chen
2014-12-02 10:11   ` Tian, Kevin
2014-12-02 20:40   ` Konrad Rzeszutek Wilk
2014-12-04 17:05   ` Jan Beulich
2014-12-01  9:24 ` [v8][PATCH 17/17] xen/vtd: re-enable USB device assignment if enable pci_force Tiejun Chen
2014-12-05 16:12   ` Konrad Rzeszutek Wilk
2014-12-02 19:17 ` [v8][PATCH 00/17] xen: RMRR fix Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417425875-9634-12-git-send-email-tiejun.chen@intel.com \
    --to=tiejun.chen@intel.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=kevin.tian@intel.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.