From: Ian Campbell <Ian.Campbell@citrix.com>
To: "Hu, Robert" <robert.hu@intel.com>
Cc: "wei.liu2@citrix.com" <wei.liu2@citrix.com>,
"Pang, LongtaoX" <longtaox.pang@intel.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
"Zheng, Di" <di.zheng@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [OSSTEST PATCH 0/4] Introduction of the patches.
Date: Mon, 1 Dec 2014 09:32:23 +0000 [thread overview]
Message-ID: <1417426343.23604.72.camel@citrix.com> (raw)
In-Reply-To: <9E79D1C9A97CFD4097BCE431828FDD31A723E1@SHSMSX103.ccr.corp.intel.com>
On Mon, 2014-12-01 at 05:27 +0000, Hu, Robert wrote:
> > But I'm not convinced that these patches take the right approach to
> > achieving that. There seems to be a great deal of duplication of
> > code. I think we should have a conversation about what moving parts
> > are necessary for nested HVM testing.
> Agree with you we shall reuse existing ts-* if possible. Actually I had thought of this approach but later I
> defeated myself because I thought ts-* shall compromise itself as a whole test case and better not to touch them.
> Now I see that ts- is more like components to constitute a test case (my current understanding is your job == test cases).
Have you seen the README at the top-level of osstest.git? It starts with
a terminology section, which includes defining what a job is: a sequence
of test steps, which could also be called a test case. The ts-* prefix
stands for test step BTW.
There is certainly scope for improving the docs though so please do ask
if anything is unclear and we can improve the docs.
Ian.
next prev parent reply other threads:[~2014-12-01 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 7:45 [OSSTEST PATCH 0/4] Introduction of the patches longtao.pang
2014-11-28 7:45 ` [OSSTEST PATCH 1/4] Add nested testcase of preparing and installing L1 guest longtao.pang
2014-11-28 7:45 ` [OSSTEST PATCH 2/4] Building XEN and HVM Dom0 kernel for L1 guest VM longtao.pang
2014-11-28 7:45 ` [OSSTEST PATCH 3/4] Add nested test case of installing L2 " longtao.pang
2014-11-28 7:45 ` [OSSTEST PATCH 4/4] Insert nested test job name and runvars longtao.pang
2014-11-28 12:26 ` [OSSTEST PATCH 0/4] Introduction of the patches Ian Jackson
2014-12-01 5:27 ` Hu, Robert
2014-12-01 9:32 ` Ian Campbell [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-10 8:07 longtao.pang
2014-12-11 10:38 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417426343.23604.72.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=di.zheng@intel.com \
--cc=longtaox.pang@intel.com \
--cc=robert.hu@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.