From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 for-4.5 0/2] xl/libxl: fix API and two memory leaks Date: Mon, 1 Dec 2014 11:40:09 +0000 Message-ID: <1417434009.29138.13.camel@citrix.com> References: <1417433473-17272-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1417433473-17272-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2014-12-01 at 11:31 +0000, Wei Liu wrote: > Return value of libxl_basename was erroneously marked as "const". This > series removes that "const" and fixes two memory leaks in xl. > > I think these fixes should be included in 4.5, given that they fix real > issues and are very straight foward to reason about. Agreed. Both patches: Acked-by: Ian Campbell I've added the CCs to this intro mail... Did you by any chance look for other const char * return values? Ian.