From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v2 for-4.5 0/2] xl/libxl: fix API and two
 memory leaks
Date: Mon, 1 Dec 2014 11:51:15 +0000
Message-ID: <1417434675.29138.17.camel@citrix.com>
References: <1417433473-17272-1-git-send-email-wei.liu2@citrix.com>
	<1417434009.29138.13.camel@citrix.com>
	<20141201115044.GA19889@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20141201115044.GA19889@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2014-12-01 at 11:50 +0000, Wei Liu wrote:
> On Mon, Dec 01, 2014 at 11:40:09AM +0000, Ian Campbell wrote:
> > On Mon, 2014-12-01 at 11:31 +0000, Wei Liu wrote:
> > > Return value of libxl_basename was erroneously marked as "const". This
> > > series removes that "const" and fixes two memory leaks in xl.
> > > 
> > > I think these fixes should be included in 4.5, given that they fix real
> > > issues and are very straight foward to reason about.
> > 
> > Agreed. Both patches:
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > I've added the CCs to this intro mail...
> > 
> > Did you by any chance look for other const char * return values?
> > 
> 
> I've looked at other public API headers. I didn't spot other obvious
> problems with regard to const char * return values.

Super, thanks!