From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: irq: fix buggy usage of irq_data irq field
Date: Mon, 01 Dec 2014 18:16:37 +0100 [thread overview]
Message-ID: <1417454197.4624.30.camel@pengutronix.de> (raw)
In-Reply-To: <1417454074.4624.28.camel@pengutronix.de>
Am Montag, den 01.12.2014, 18:14 +0100 schrieb Philipp Zabel:
> Am Montag, den 01.12.2014, 17:03 +0000 schrieb Marc Zyngier:
> > On 01/12/14 17:00, Fabio Estevam wrote:
> > > Hi Marc,
> > >
> > > On Mon, Dec 1, 2014 at 2:25 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> > >> mach-imx directly references to the irq field in
> > >> struct irq_data, and uses this to directly poke hardware register.
> > >>
> > >> But irq is the *virtual* irq number, something that has nothing
> > >> to do with the actual HW irq (stored in the hwirq field). And once
> > >> we put the stacked domain code in action, the whole thing explodes,
> > >> as these two values are *very* different.
> > >>
> > >> Just replacing all instances of irq with hwirq fixes the issue.
> > >>
> > >> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> > >
> > > I tested your patch and I still have the following problem on a mx6q:
> >
> > [...]
> >
> > > This issue does not happen on linux-next 20141126, but it stats at 201411267.
> > >
> > > I haven't bisect it yet, but if you have any ideas, please let me know. Thanks
> >
> > I do have an idea indeed, as well as a patch for this. I'll put you on
> > Cc, watch that space.
>
> I've just arrived att his workaround for the issue by just directly
> going to hwirq 32, please put me on Cc, too.
Never mind that, I just got that mail. Thanks!
regards
Philipp
next prev parent reply other threads:[~2014-12-01 17:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 16:25 [PATCH] ARM: imx: irq: fix buggy usage of irq_data irq field Marc Zyngier
2014-12-01 17:00 ` Fabio Estevam
2014-12-01 17:03 ` Marc Zyngier
2014-12-01 17:14 ` Philipp Zabel
2014-12-01 17:16 ` Philipp Zabel [this message]
2014-12-01 17:12 ` Philipp Zabel
2014-12-01 17:14 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417454197.4624.30.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.