From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 for-4.5 0/2] xl/libxl: fix API and two memory leaks Date: Tue, 2 Dec 2014 15:35:02 +0000 Message-ID: <1417534502.24320.58.camel@citrix.com> References: <1417433473-17272-1-git-send-email-wei.liu2@citrix.com> <20141201215416.GF24289@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141201215416.GF24289@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2014-12-01 at 16:54 -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Dec 01, 2014 at 11:31:11AM +0000, Wei Liu wrote: > > Return value of libxl_basename was erroneously marked as "const". This > > series removes that "const" and fixes two memory leaks in xl. > > > > I think these fixes should be included in 4.5, given that they fix real > > issues and are very straight foward to reason about. > > Thank you for catching those! > > Release-Acked-by: Konrad Rzeszutek Wilk Applied both, including the modification discussed in my reply to the second. > > > > Wei. > > > > Wei Liu (2): > > libxl: un-constify return value of libxl_basename > > xl: fix two memory leaks > > > > tools/libxl/libxl.h | 10 ++++++++++ > > tools/libxl/libxl_utils.c | 5 ++++- > > tools/libxl/libxl_utils.h | 6 +++++- > > tools/libxl/xl_cmdimpl.c | 8 ++++++-- > > 4 files changed, 25 insertions(+), 4 deletions(-) > > > > -- > > 1.7.10.4 > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel