From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] libxl: Don't derefence null new_name
 pointer in libxl_domain_rename()
Date: Tue, 2 Dec 2014 15:35:33 +0000
Message-ID: <1417534533.24320.59.camel@citrix.com>
References: <1417444026-31044-1-git-send-email-euan.harris@citrix.com>
	<1417445456.29138.33.camel@citrix.com>
	<20141201220242.GI24289@laptop.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20141201220242.GI24289@laptop.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Ian.Jackson@eu.citrix.com, Euan Harris <euan.harris@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2014-12-01 at 17:02 -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Dec 01, 2014 at 02:50:56PM +0000, Ian Campbell wrote:
> > On Mon, 2014-12-01 at 14:27 +0000, Euan Harris wrote:
> > > libxl__domain_rename() unconditionally dereferences its new_name
> > > parameter, to check whether it is an empty string.   Add a check to
> > > avoid a segfault if new_name is null.
> > > 
> > > Signed-off-by: Euan Harris <euan.harris@citrix.com>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > I think this is a good fix to have for 4.5, Konrad CCd.
> 
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Applied, fixing the typo in the subject as I went.