From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability Date: Wed, 3 Dec 2014 10:51:10 +0000 Message-ID: <1417603870.11243.10.camel@citrix.com> References: <1417533090-29651-1-git-send-email-wei.liu2@citrix.com> <20141202183755.GF32385@laptop.dumpdata.com> <20141203102636.GA29307@aepfle.de> <1417602539.11243.4.camel@citrix.com> <20141203104912.GA30431@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141203104912.GA30431@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Mark Pryor , Wei Liu , "Luis R. Rodriguez" , Ian Jackson , xen-devel@lists.xen.org, m.a.young@durham.ac.uk, Anthony Perard List-Id: xen-devel@lists.xenproject.org On Wed, 2014-12-03 at 11:49 +0100, Olaf Hering wrote: > On Wed, Dec 03, Ian Campbell wrote: > > > Ah I didn't know about the sd_listen_fds thing, so I think that what we > > need then is to use pkg-config first to determine if systemd-daemon is > > present at all, and then check for specific symbols we require using the > > pkg-config supplied CFLAGS and LDFLAGS rather than assuming > > -lsystemd-daemon. > > Correction: sd_listen_fds is available since at least v1. > git describe --contains abbbea81a8fa70badb7a05e518d6b07c360fc09d > v1~390 In that case I don't think we realistically need to check for it? Ian.