From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id DF300E00521; Wed, 3 Dec 2014 15:10:25 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (bisson.gary[at]gmail.com) * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.220.48 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id BA215E002F9 for ; Wed, 3 Dec 2014 15:10:22 -0800 (PST) Received: by mail-pa0-f48.google.com with SMTP id rd3so16706969pab.21 for ; Wed, 03 Dec 2014 15:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=MmsQgW9I7/JqkkGLGJgyzguYAxNI6wO/Cr9rflMBY0Q=; b=pbcm87d8B6l2kKs+QtuXWpq4pC55GY+d6cavFO/e8m3MBgXHMSg8yK/SEZzb/V3vdX UxRDYV1NH5P0R7wn7iNAOiDP0PHXWuj3KK+rPheBo+DjP0E8PBs+yAt3kojYzJBUPLGL /GPd34594rxsnjzL948E/mRPuk1w9Aqf4qo861Vqn5+3Cci2uoR1hbxSom31bN6+4v4+ AB2zwVTr8YnoMPaTzPkyde6ESN4G99o2e1hGHxF5a1fd+1vrnSQD1pkX3i65CiL1jwym k+CdPvb89bAAOvMf7AQvuYumGzWjjedA7BeDXeQ9yD82pqAvpfBiOkpiFGptILOSsoi+ OUlA== X-Received: by 10.70.90.80 with SMTP id bu16mr13539052pdb.44.1417648221483; Wed, 03 Dec 2014 15:10:21 -0800 (PST) Received: from e6430.adeneo-embedded.us (173-10-76-58-BusName-Washington.hfc.comcastbusiness.net. [173.10.76.58]) by mx.google.com with ESMTPSA id v4sm24026428pbs.10.2014.12.03.15.10.20 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Dec 2014 15:10:20 -0800 (PST) From: Gary Bisson To: meta-freescale@yoctoproject.org Date: Wed, 3 Dec 2014 15:10:11 -0800 Message-Id: <1417648211-30759-1-git-send-email-bisson.gary@gmail.com> X-Mailer: git-send-email 2.1.3 Cc: fabio.estevam@freescale.com, Gary Bisson , otavio@ossystems.com.br Subject: [PATCH v3] linux-imx: add clock patch for revision T0 1.0 of i.MX6Q X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Dec 2014 23:10:25 -0000 The post dividers do not work on i.MX6Q rev T0 1.0 so they must be fixed to 1. As the table index was wrong, a divider a of 4 could still be requested which implied the clock not to be set properly. This is the root cause of the HDMI not working at high resolution on rev T0 1.0 of the SoC, giving the following error: mxc_sdc_fb fb.27: timeout when waiting for flip irq Signed-off-by: Gary Bisson --- Changes v2->v3: - Move upstream-status into patch commit log as suggested by Otavio Changes v1->v2: - Reword commit log as suggested by Diaine This patch has been tested with a Sabrelite rev D (5-9-12). However I've realized this patch doesn't fix the HDMI at 1080p60 when testing Eric's patches on mainline. The reason for it is that 6x_bootscript fixes the resolution at 720p30 which now works great when using FSL kernel. But mainline kernel is forcing 1080p60 by default and can't seem to be changed (don't know what video parameters to use). Doing more testing on FSL kernel proved that it works only up to 1080p30 but using 60fps seems to still be broken. It is to be noted that the error message doesn't appear anymore. I'll try to compare again the IMX_CHIP_REVISION checks between the 3.0.35 and the 3.10.17 as 1080p60 works on 3.0.35. I figured it might still be worth integrating this patch as the clock index is clearly wrong. In the meantime I'll work on getting 1080p60 fixed. Only then I will submit the patches to the lkml. Let me know your thoughts. Thanks! --- ...6q-fix-video-divider-for-revision-1.0-of-.patch | 35 ++++++++++++++++++++++ recipes-kernel/linux/linux-imx_3.10.17.bb | 2 ++ 2 files changed, 37 insertions(+) create mode 100644 recipes-kernel/linux/linux-imx-3.10.17/0001-ARM-clk-imx6q-fix-video-divider-for-revision-1.0-of-.patch diff --git a/recipes-kernel/linux/linux-imx-3.10.17/0001-ARM-clk-imx6q-fix-video-divider-for-revision-1.0-of-.patch b/recipes-kernel/linux/linux-imx-3.10.17/0001-ARM-clk-imx6q-fix-video-divider-for-revision-1.0-of-.patch new file mode 100644 index 0000000..3d13b6f --- /dev/null +++ b/recipes-kernel/linux/linux-imx-3.10.17/0001-ARM-clk-imx6q-fix-video-divider-for-revision-1.0-of-.patch @@ -0,0 +1,35 @@ +From ffcd8b98f6ba3a2b7a4aecc1e5e454de5fa5c4c3 Mon Sep 17 00:00:00 2001 +From: Gary Bisson +Date: Tue, 2 Dec 2014 22:11:14 -0800 +Subject: [PATCH] ARM: clk-imx6q: fix video divider for revision 1.0 of i.MX6q + +As post dividers do not work on i.MX6Q revision 1.0 they must be fixed +to 1. As the table index was wrong, a divider a of 4 could still be +requested which implied the clock not to be set properly. This is the +root cause of the HDMI not working at high resolution on T1.0 version of +the SoC, giving the following error: +mxc_sdc_fb fb.27: timeout when waiting for flip irq + +Upstream-Status: Pending + +Signed-off-by: Gary Bisson +--- + arch/arm/mach-imx/clk-imx6q.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c +index e09b1e8..1e5c410 100644 +--- a/arch/arm/mach-imx/clk-imx6q.c ++++ b/arch/arm/mach-imx/clk-imx6q.c +@@ -279,7 +279,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node) + post_div_table[1].div = 1; + post_div_table[2].div = 1; + video_div_table[1].div = 1; +- video_div_table[2].div = 1; ++ video_div_table[3].div = 1; + }; + + /* type name parent_name base div_mask */ +-- +2.1.3 + diff --git a/recipes-kernel/linux/linux-imx_3.10.17.bb b/recipes-kernel/linux/linux-imx_3.10.17.bb index cae1489..143eaab 100644 --- a/recipes-kernel/linux/linux-imx_3.10.17.bb +++ b/recipes-kernel/linux/linux-imx_3.10.17.bb @@ -15,4 +15,6 @@ SRCBRANCH = "imx_3.10.17_1.0.0_ga" SRCREV = "33597e348b2d60dd5c71890ef7b7d3d3fd6e4e97" LOCALVERSION = "-1.0.2_ga" +SRC_URI += "file://0001-ARM-clk-imx6q-fix-video-divider-for-revision-1.0-of-.patch" + COMPATIBLE_MACHINE = "(mx6)" -- 2.1.3