From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools/hotplug: update systemd dependency to use service instead of socket Date: Thu, 4 Dec 2014 13:25:39 +0000 Message-ID: <1417699539.22808.30.camel@citrix.com> References: <1417534763-25053-1-git-send-email-olaf@aepfle.de> <1417535095.29004.4.camel@citrix.com> <20141202184240.GI32385@laptop.dumpdata.com> <20141202204245.GO357@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141202204245.GO357@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Olaf Hering , Wei Liu , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org, M A Young List-Id: xen-devel@lists.xenproject.org On Tue, 2014-12-02 at 15:42 -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 02, 2014 at 06:51:50PM +0000, M A Young wrote: > > On Tue, 2 Dec 2014, Konrad Rzeszutek Wilk wrote: > > > > >On Tue, Dec 02, 2014 at 03:44:55PM +0000, Ian Campbell wrote: > > >>On Tue, 2014-12-02 at 16:39 +0100, Olaf Hering wrote: > > >>>Since commit 4542ae340d75bd6319e3fcd94e6c9336e210aeef ("tools/hotplug: > > >>>systemd xenstored dependencies") all service files use the .socket unit > > >>>as startup dependency. While this happens to work for boot it fails for > > >>>shutdown because a .socket does not seem to enforce ordering. When > > >>>xendomains.service runs during shutdown then systemd will stop > > >>>xenstored.service at the same time. > > >>> > > >>>Change all "xenstored.socket" to "xenstored.service" to let systemd know > > >>>that xenstored has to be shutdown after everything else. > > >>> > > >>>Reported-by: Mark Pryor > > >>>Signed-off-by: Olaf Hering > > >>>Cc: Ian Jackson > > >>>Cc: Stefano Stabellini > > >> > > >>Acked-by: Ian Campbell > > >> > > >>>Cc: Wei Liu > > >>>--- > > >>> > > >>>This should go into 4.5 to fix xendomains.service. > > >> > > >>CCing Konrad... > > > > > >CC-ing Michael. > > > > > >Michael, since Fedora is using systemd, did you observe this bug as well? > > >(I think I did, but I might have blamed it on my wacky setup). > > > > I only tried the xen systemd on xen 4.5-rc2 and didn't have a lot of success > > even when I reverted to Fedora's systemd for xen, so I can't really comment. > > Ugh. > > I did have issues with xen systemd which I shall report if they are still > > there in -rc3. > > OK, lets then go with this. > > Release-Acked-by: Konrad Rzeszutek Wilk Applied, thanks. > > > > Michael Young