From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH for-4.5 2/3] python/xc: Fix multiple issues
 in pyxc_readconsolering()
Date: Thu, 4 Dec 2014 13:26:15 +0000
Message-ID: <1417699575.22808.32.camel@citrix.com>
References: <1417091674-8163-1-git-send-email-andrew.cooper3@citrix.com>
	<1417091674-8163-3-git-send-email-andrew.cooper3@citrix.com>
	<1417174732.23604.13.camel@citrix.com>
	<20141201211456.GH22021@laptop.dumpdata.com>
	<1417528237.24320.34.camel@citrix.com>
	<20141202184749.GC32622@laptop.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20141202184749.GC32622@laptop.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen Coverity Team <coverity@xen.org>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2014-12-02 at 13:47 -0500, Konrad Rzeszutek Wilk wrote:
> On Tue, Dec 02, 2014 at 01:50:37PM +0000, Ian Campbell wrote:
> > On Mon, 2014-12-01 at 16:14 -0500, Konrad Rzeszutek Wilk wrote:
> > > On Fri, Nov 28, 2014 at 11:38:52AM +0000, Ian Campbell wrote:
> > > > On Thu, 2014-11-27 at 12:34 +0000, Andrew Cooper wrote:
> > > > > Don't leak a 16k allocation if PyArg_ParseTupleAndKeywords() or the first
> > > > > xc_readconsolering() fail.  It is trivial to run throught the processes memory
> > > > > by repeatedly passing junk parameters to this function.
> > > > > 
> > > > > In the case that the call to xc_readconsolering() in the while loop fails,
> > > > > reinstate str before breaking out, and passing a spurious pointer to free().
> > > > > 
> > > > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > > > > Coverity-IDs: 1054984 1055906
> > > > > CC: Ian Campbell <Ian.Campbell@citrix.com>
> > > > > CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > > > > CC: Wei Liu <wei.liu2@citrix.com>
> > > > > CC: Xen Coverity Team <coverity@xen.org>
> > > > 
> > > > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > > 
> > > Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > 
> > Did you intend to also ack patch #1? (or have I missed a mail?)
> 
> No. You two still were discussing it so I figured I will wait
> until a repost.

I've applied these two.

FWIW despite the discussion I think the first could go in too, and
probably doesn't need a resend.