From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] libxc: check in xc_get_tot_pages() that the proper domain is reported Date: Thu, 4 Dec 2014 13:26:48 +0000 Message-ID: <1417699608.22808.33.camel@citrix.com> References: <1417533488-15787-1-git-send-email-vkuznets@redhat.com> <20141202160444.GI5768@zion.uk.xensource.com> <20141202184326.GJ32385@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141202184326.GJ32385@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Andrew Jones , Wei Liu , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org, Vitaly Kuznetsov List-Id: xen-devel@lists.xenproject.org On Tue, 2014-12-02 at 13:43 -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 02, 2014 at 04:04:44PM +0000, Wei Liu wrote: > > On Tue, Dec 02, 2014 at 04:18:08PM +0100, Vitaly Kuznetsov wrote: > > > XEN_DOMCTL_getdomaininfo, which is being used by xc_domain_getinfo(), has > > > strange interface: it reports first domain which has domid >= requested domid > > > so all callers are supposed to check that the proper domain(s) was queried > > > by checking domid. xc_get_tot_pages() doesn't do that. In case the requested > > > domain was destroyed it will report first domain with domid > requested domid > > > which is apparently misleading as there is no way xc_get_tot_pages() callers > > > can figure out that they got tot_pages for some other domain. > > > > > > Signed-off-by: Vitaly Kuznetsov > > > > Acked-by: Wei Liu > > Lets add another Ack to this party.. > > Release-Acked-by: Konrad Rzeszutek Wilk Applied, thanks.