From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.5] pygrub: Fix regression from c/s d1b93ea, attempt 2 Date: Thu, 4 Dec 2014 13:26:55 +0000 Message-ID: <1417699615.22808.34.camel@citrix.com> References: <1416931910-8222-1-git-send-email-boris.ostrovsky@oracle.com> <1417174284.23604.9.camel@citrix.com> <20141201203001.GE21626@laptop.dumpdata.com> <547D276C.2070805@citrix.com> <1417528978.24320.42.camel@citrix.com> <20141202150933.GE27869@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141202150933.GE27869@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Andrew Cooper , Boris Ostrovsky , Ian.Jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2014-12-02 at 10:09 -0500, Konrad Rzeszutek Wilk wrote: > > At this point in a freeze I'm much happier with: > > > > tools/pygrub/src/pygrub | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > The same here. This is now the season of handing out band-aids. > > As such Release-Acked-by: Konrad Rzeszutek Wilk Applied. > > > > than > > tools/pygrub/src/ExtLinuxConf.py | 6 +++--- > > tools/pygrub/src/GrubConf.py | 7 ++----- > > tools/pygrub/src/LiloConf.py | 6 +++--- > > 3 files changed, 8 insertions(+), 11 deletions(-) > > > > Plus Boris' patch is far easier to reason about in isolation in a > > dynamically/duck typed language. > > > > Ian. > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel