From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability Date: Thu, 4 Dec 2014 13:27:26 +0000 Message-ID: <1417699646.22808.36.camel@citrix.com> References: <201412041214.sB4CEoXn022467@aserz7021.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201412041214.sB4CEoXn022467@aserz7021.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Mark Pryor , Olaf Hering , Wei Liu , "Luis R. Rodriguez" , Ian Jackson , xen-devel@lists.xen.org, M A Young , Anthony Perard List-Id: xen-devel@lists.xenproject.org On Thu, 2014-12-04 at 07:13 -0500, Konrad Rzeszutek Wilk wrote: > On Dec 4, 2014 6:55 AM, Ian Campbell wrote: > > > > On Wed, 2014-12-03 at 10:51 +0000, Ian Campbell wrote: > > > On Wed, 2014-12-03 at 11:49 +0100, Olaf Hering wrote: > > > > On Wed, Dec 03, Ian Campbell wrote: > > > > > > > > > Ah I didn't know about the sd_listen_fds thing, so I think that what we > > > > > need then is to use pkg-config first to determine if systemd-daemon is > > > > > present at all, and then check for specific symbols we require using the > > > > > pkg-config supplied CFLAGS and LDFLAGS rather than assuming > > > > > -lsystemd-daemon. > > > > > > > > Correction: sd_listen_fds is available since at least v1. > > > > git describe --contains abbbea81a8fa70badb7a05e518d6b07c360fc09d > > > > v1~390 > > > > > > In that case I don't think we realistically need to check for it? > > > > The implication here being that Wei's original patch is correct. Konrad, > > do you think this is OK for the release? > > > > > > > Yes. Release-Axked-By: Konrad Rzeszutek Wilk Applied, thanks. > > > Ian. > > > > > > > > > > > > _______________________________________________ > > > Xen-devel mailing list > > > Xen-devel@lists.xen.org > > > http://lists.xen.org/xen-devel > > > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > http://lists.xen.org/xen-devel