From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: A few EFI code questions Date: Fri, 5 Dec 2014 09:52:08 +0000 Message-ID: <1417773128.22808.48.camel@citrix.com> References: <20141203210225.GR16236@olila.local.net-space.pl> <548038D5020000780004C9E8@mail.emea.novell.com> <54816EC3020000780004CFF3@mail.emea.novell.com> <1417771988.22808.40.camel@citrix.com> <54818D2A020000780004D0CA@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XwpYk-0007QK-R0 for xen-devel@lists.xenproject.org; Fri, 05 Dec 2014 09:52:22 +0000 In-Reply-To: <54818D2A020000780004D0CA@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: keir , Andrew Cooper , Daniel Kiper , Stefano Stabellini , Roy Franz , xen-devel List-Id: xen-devel@lists.xenproject.org On Fri, 2014-12-05 at 09:47 +0000, Jan Beulich wrote: > >>> On 05.12.14 at 10:33, wrote: > > On Fri, 2014-12-05 at 07:37 +0000, Jan Beulich wrote: > >> >>> On 04.12.14 at 22:22, wrote: > >> > On Thu, Dec 4, 2014 at 1:35 AM, Jan Beulich wrote: > >> >>>>> On 03.12.14 at 22:02, wrote: > >> >>> 3) Should not we change xen/arch/*/efi/efi-boot.h to > >> >>> xen/arch/*/efi/efi-boot.c? efi-boot.h contains more > >> >>> code than definitions, declarations and short static > >> >>> functions. So, I think that it is more regular *.c file > >> >>> than header file. > >> >> > >> >> That's a matter of taste - I'd probably have made it .c too, but > >> >> didn't mind it being .h as done by Roy (presumably on the basis > >> >> that #include directives are preferred to have .h files as their > >> >> operands). The only thing I regret is that I didn't ask for the > >> >> pointless efi- prefix to be dropped. > >> > > >> > I don't mind a change here, and I agree that it is more like a .c file > >> > than a .h. If a name change is done, is it worth dropping the "efi-" at > >> > the same time? > >> > >> If we indeed want to change the name (post 4.5), making both > >> adjustments at once would be kind of a requirement of mine. > > > > Random thought: *.inc for .c files which happen to be embedded into > > another using #include? > > That may conflict with certain editors' language detection, as .inc > may have other meanings (in the x86 Windows world I'd expect this > to be an assembler include file for example). Oh, so does my emacs apparently (a leftover .emacs snippet from a previous life...). Nevermind that suggestion then. The existing comment at the top of the included files is probably sufficient. Ian.