From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability Date: Fri, 5 Dec 2014 09:59:48 +0000 Message-ID: <1417773588.22808.52.camel@citrix.com> References: <1417533090-29651-1-git-send-email-wei.liu2@citrix.com> <20141205095146.GA16843@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141205095146.GA16843@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Mark Pryor , Wei Liu , "Luis R. Rodriguez" , Ian Jackson , xen-devel@lists.xen.org, Anthony Perard List-Id: xen-devel@lists.xenproject.org On Fri, 2014-12-05 at 10:51 +0100, Olaf Hering wrote: > On Tue, Dec 02, Wei Liu wrote: > > > AC_CHECK_LIB fails on Debian Jessie since the ld flag it generates is > > incorrect, even in the event systemd library is available. Use > > PKG_CHECK_MODULES instead. > > > > Tested on Debian Jessie and Arch Linux. > > I just tested this and got this failure. The reason is that the LDFLAGS come > before the objects. If I move LDFLAGS after $^ linking works. Will send a patch > to fix the failure. Was this a new failure with this change? AFAICT LDFLAGS is still set (via SYSTEMD_LIBS) in the same place relative to non-systemd stuff. FWIW the reason I don't see this in my pre-commit test is that I don't have the systemd headers installed.