All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wesley Wiser <wwiser@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] checkpatch: allow uppercase logging function names
Date: Sat, 06 Dec 2014 03:28:06 +0000	[thread overview]
Message-ID: <1417836486.4713.2.camel@gmail.com> (raw)
In-Reply-To: <1417660721-13330-1-git-send-email-wwiser@gmail.com>

Hi Joe, 

Thanks for taking a look at this. Do you think I should look into
fixing the casing of these functions instead? Some of these functions
look like they're being called in a lot of places. TP_printk, for
example, is getting called over 1000 times according to git grep. 

Wesley Wiser

On Wed, 2014-12-03 at 18:47 -0800, Joe Perches wrote:
> I'm not sure that these should be encouraged.
> I'd prefer to make these lower case instead.
> 
> The regex also allows mixed case like Tp_printk.
> 
> Maybe if it was something like
> (?:[a-z0-9]+_|[A-Z0-9]+_){1,2}
> 
> but it still seems undesirable.



      parent reply	other threads:[~2014-12-06  3:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04  2:38 [PATCH] checkpatch: allow uppercase logging function names Wesley Wiser
2014-12-04  2:47 ` Joe Perches
2014-12-04  8:54 ` Dan Carpenter
2014-12-06  3:28 ` Wesley Wiser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417836486.4713.2.camel@gmail.com \
    --to=wwiser@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.