From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: is the commit 571dcfde2371 (net-next) a proper fix? Date: Mon, 08 Dec 2014 12:23:20 +0200 Message-ID: <1418034200.17201.45.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Giuseppe Cavallaro , "David S. Miller" , netdev To: Huacai Chen Return-path: Received: from mga09.intel.com ([134.134.136.24]:2180 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144AbaLHKXV (ORCPT ); Mon, 8 Dec 2014 05:23:21 -0500 Sender: netdev-owner@vger.kernel.org List-ID: Hi! It seems for me that commit 571dcfde2371 (stmmac: platform: fix default values of the filter bins setting) is redundant (moreover, it could be a cause of crash in some cases when there is no platform data defined in case of CONFIG_OF). In case of no OF the platform data should be provided by platform code where the defaults are set. What did I miss? -- Andy Shevchenko Intel Finland Oy