From: Paul Bolle <pebolle@tiscali.nl>
To: Christoph Jaeger <cj@linux.com>
Cc: Daniel Borkmann <dborkman@redhat.com>,
yann.morin.1998@free.fr, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 2/3] kconfig: remove undocumented type definition alias 'boolean'
Date: Mon, 08 Dec 2014 20:41:25 +0100 [thread overview]
Message-ID: <1418067685.2058.27.camel@x220> (raw)
In-Reply-To: <5485F923.3090301@redhat.com>
On Mon, 2014-12-08 at 20:16 +0100, Daniel Borkmann wrote:
> On 12/08/2014 08:13 PM, Paul Bolle wrote:
> > On Mon, 2014-12-08 at 19:51 +0100, Paul Bolle wrote:
> >> This doesn't apply on next-20141208. What tree did you base this on?
> >
> > I got it to apply on next-20141208 by dropping the hunk for
> > arch/cris/arch-v32/drivers/Kconfig and by making (trivial) context
> > changes to the hunks for init/Kconfig and net/Kconfig.
> >
> > (My experience with actual maintainers is that they won't bother to do
> > that. Anyhow, Kconfig is basically unmaintained. And I don't know which
> > tree one should base ones Kconfig patches on.)
>
> Well, I guess if in doubt then this could go into Andrew's tree. :)
>
> > I'll muddle along...
Checking this on the in tree defconfig files gave me a few hundred, it
seems, errors like:
net/switchdev/Kconfig:7: syntax error
net/switchdev/Kconfig:6: unknown option "boolean"
drivers/hwmon/pmbus/Kconfig:61: syntax error
drivers/hwmon/pmbus/Kconfig:60: unknown option "boolean"
drivers/usb/gadget/Kconfig:373: syntax error
drivers/usb/gadget/Kconfig:372: unknown option "boolean"
drivers/usb/gadget/Kconfig:386: syntax error
drivers/usb/gadget/Kconfig:385: unknown option "boolean"
drivers/usb/gadget/Kconfig:404: syntax error
drivers/usb/gadget/Kconfig:403: unknown option "boolean"
drivers/usb/gadget/Kconfig:418: syntax error
drivers/usb/gadget/Kconfig:417: unknown option "boolean"
make[1]: *** [oldconfig] Error 1
make: *** [oldconfig] Error 2
I assume these are uses of "boolean" added by trees merged in
next-20141208 after the tree that you based your patch on.
Well, it seems the treewide "boolean" cleanup should be done first.
Removing support for "boolean" could than be a second, separate step.
Just to ease review.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2014-12-08 19:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 1:49 [PATCH 0/3] remove undocumented type definition alias Christoph Jaeger
2014-12-08 1:49 ` [PATCH 1/3] kconfig: regenerate parser Christoph Jaeger
2014-12-08 20:28 ` Paul Bolle
2014-12-08 1:49 ` [PATCH 2/3] kconfig: remove undocumented type definition alias 'boolean' Christoph Jaeger
2014-12-08 18:51 ` Paul Bolle
2014-12-08 19:13 ` Paul Bolle
2014-12-08 19:16 ` Daniel Borkmann
2014-12-08 19:41 ` Paul Bolle [this message]
2014-12-08 20:36 ` Paul Bolle
2014-12-08 21:15 ` Paul Bolle
2014-12-09 11:49 ` Daniel Borkmann
2014-12-09 23:14 ` Christoph Jaeger
2014-12-08 1:49 ` [PATCH 3/3] kconfig: rename S_BOOLEAN to S_BOOL for consistency Christoph Jaeger
2014-12-08 20:43 ` Paul Bolle
2014-12-08 20:20 ` [PATCH 0/3] remove undocumented type definition alias Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418067685.2058.27.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=cj@linux.com \
--cc=dborkman@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.