From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: chenhc@lemote.com, peppe.cavallaro@st.com, netdev@vger.kernel.org
Subject: Re: is the commit 571dcfde2371 (net-next) a proper fix?
Date: Tue, 09 Dec 2014 11:25:10 +0200 [thread overview]
Message-ID: <1418117110.17201.52.camel@linux.intel.com> (raw)
In-Reply-To: <20141208.193532.411317230886917624.davem@davemloft.net>
On Mon, 2014-12-08 at 19:35 -0500, David Miller wrote:
> > It seems for me that commit 571dcfde2371 (stmmac: platform: fix default
> > values of the filter bins setting) is redundant (moreover, it could be a
> > cause of crash in some cases when there is no platform data defined in
> > case of CONFIG_OF).
> >
> > In case of no OF the platform data should be provided by platform code
> > where the defaults are set. What did I miss?
>
> You missed follow-up fix:
>
> commit 28603d13997e2ef47f18589cc9a44553aad49c86
> Author: Huacai Chen <chenhc@lemote.com>
> Date: Thu Nov 27 21:05:34 2014 +0800
>
> stmmac: platform: Move plat_dat checking earlier
Thanks, now it makes sense, indeed.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
prev parent reply other threads:[~2014-12-09 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 10:23 is the commit 571dcfde2371 (net-next) a proper fix? Andy Shevchenko
2014-12-09 0:35 ` David Miller
2014-12-09 9:25 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418117110.17201.52.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=chenhc@lemote.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.