From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-xen-4.5 1/3] tools/hotplug: distclean target should remove files generated by configure Date: Tue, 9 Dec 2014 14:35:37 +0000 Message-ID: <1418135737.14361.71.camel@citrix.com> References: <1417533390-29035-1-git-send-email-daniel.kiper@oracle.com> <1417533390-29035-2-git-send-email-daniel.kiper@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XyLtG-0006Cu-UP for xen-devel@lists.xenproject.org; Tue, 09 Dec 2014 14:35:51 +0000 In-Reply-To: <1417533390-29035-2-git-send-email-daniel.kiper@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Daniel Kiper Cc: xen-devel@lists.xenproject.org, keir@xen.org, ian.jackson@eu.citrix.com, jbeulich@suse.com, andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, 2014-12-02 at 16:16 +0100, Daniel Kiper wrote: > +distclean: > + rm -f Linux/init.d/sysconfig.xencommons Linux/init.d/xencommons NetBSD/rc.d/xencommons Configure generates a boatload more things than this, see e.g. $ grep hotplug/ tools/configure.ac Perhaps the answer would be to recurse into tools/hotplug/* and refactor the existing XEN_SCRIPTS to have the generated stuff in XEN_SCRIPTS_GEN instead and XEN_SCRIPTS += $(XEN_SCRIPTS). The on distclean remove the XEN_SCRIPTS_GEN ones. It's not ideal, but at least it puts the distclean logic in the same place as the logic to install the files, if not their generation, which at least increases the chance of someone adding it to the right place. Ian.