From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.5] xen/arm: Correct the opcode for BUG_INSTR on arm32 Date: Tue, 9 Dec 2014 15:06:58 +0000 Message-ID: <1418137618.19809.4.camel@citrix.com> References: <1417721215-32639-1-git-send-email-julien.grall@linaro.org> <20141204193434.GB6225@laptop.dumpdata.com> <1417776878.22808.56.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XyMPQ-0008N4-Ty for xen-devel@lists.xenproject.org; Tue, 09 Dec 2014 15:09:05 +0000 In-Reply-To: <1417776878.22808.56.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, Julien Grall , tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2014-12-05 at 10:54 +0000, Ian Campbell wrote: > > > Not sure, why I dropped the 0 when I implemented the patch... > > > This is a bug fixed for Xen 4.5. This is only affected ARM32 where the > > > BUG opcode was malformed. > > > > > > With the malformed opcode, the ASSERT/BUG_ON is skipped and the > > > processor may execute another patch (because the compiler has optimized > > > > s/patch/path/ ? > > Will fix on commit. Oh, this isn't in the main body of the commit log. > > > > due the unreachable in both macro). > > > > > > The code modified is only executed when Xen is in bad state. > > > > Release-Acked-by: Konrad Rzeszutek Wilk > > Acked-by: Ian Campbell Applied (with no changes).