From: "Sérgio Basto" <sergio@serjux.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Philip Oakley <philipoakley@iee.org>,
GitList <git@vger.kernel.org>, Duy Nguyen <pclouds@gmail.com>,
Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH v2] doc: make clear --assume-unchanged's user contract
Date: Wed, 10 Dec 2014 01:49:12 +0000 [thread overview]
Message-ID: <1418176152.8290.9.camel@segulix> (raw)
In-Reply-To: <xmqqoarcjpv3.fsf@gitster.dls.corp.google.com>
On Ter, 2014-12-09 at 16:44 -0800, Junio C Hamano wrote:
> Sérgio Basto <sergio@serjux.com> writes:
>
> > Also don't understand why --assumed-untracked shouldn't deal with
> > changed files instead fallback in "the user promises not to change the
> > file" and sometimes works others not.
> >
> > Also if this is the contract when a file is different from commit,
> > should warning the user that is not in contract (modify files that are
> > assumed-untracked )
>
> Unfortunately, that is not even possible in the case where
> assume-untracked is meant to be used without breaking the use case
> it was invented to support.
OK, but when we do: git --assumed-untracked <file> and file is already
modified. we could do an warning .
May also should mention in documentation that --assumed-untracked is
not to deal with "local versions of tracked config files in git" (if you
don't)
Meanwhile I read https://gist.github.com/canton7/1423106
I adopt
https://gist.github.com/canton7/1423106#if-you-cant-modify-your-application
item 1
Thanks for your patience
> The user flips the bit so that Git does
> not have to traverse the working tree to run lstat(2) on all of them
> in order to see if some have changes relative to the index.
>
> If we cannot trust that bit and need to verify, how would we do
> that?
>
> Think.
>
> Yes, by running lstat(2) on these files that the user promised not
> to touch. That just defeats the sole objective the feature was
> invented for in the first place.
>
> Having said all that, I know what you wish to have, and I am not
> fundamentally opposed to a change to add a new feature to order Git
> to pretend that changes that may exist in the working tree are not
> there.
> It's just that assume-unchanged bit is not that. It is a
> way to allow Git that it can assume the files in the working tree
> are not changed. It is a permission, not a command.
>
> This is a tangent, but somebody may want to check the "Git will fail
> (gracefully)" bit in the documentation Philip's documentation patch
> did not remove. Such a detection is not absolutely necessary, and
> the paragraph may be describing a wishful thinking by somebody who
> misunderstood --assume-unchanged with a cursory observation of what
> happened for limited test cases back when the documentation was
> added, in which case that paragraph may also want to go.
>
>
>
>
>
>
--
Sérgio M. B.
prev parent reply other threads:[~2014-12-10 1:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 15:04 [PATCH v2] Improve --assume-unchanged in the git update-index man page Philip Oakley
2014-12-06 15:04 ` [PATCH v2] doc: make clear --assume-unchanged's user contract Philip Oakley
2014-12-09 3:43 ` Sérgio Basto
2014-12-09 7:59 ` Philip Oakley
2014-12-09 8:13 ` Philip Oakley
2014-12-09 8:30 ` Michael J Gruber
2014-12-09 11:13 ` [PATCH] gitignore.txt: do not suggest assume-unchanged Michael J Gruber
2014-12-10 1:06 ` Jonathan Nieder
2014-12-11 15:13 ` Michael J Gruber
2014-12-10 0:44 ` [PATCH v2] doc: make clear --assume-unchanged's user contract Junio C Hamano
2014-12-10 1:49 ` Sérgio Basto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418176152.8290.9.camel@segulix \
--to=sergio@serjux.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=pclouds@gmail.com \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.