From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST v3 04/11] overlay: update overlay/etc/grub.d/20_linux_xen Date: Wed, 10 Dec 2014 12:54:05 +0000 Message-ID: <1418216045.3505.28.camel@citrix.com> References: <1413323416-21778-1-git-send-email-wei.liu2@citrix.com> <1413323416-21778-5-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1413323416-21778-5-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2014-10-14 at 22:50 +0100, Wei Liu wrote: > This file was created to work around Debian bug #633127. > > According to Debian bug tracker [0], this bug is fixed in Wheezy. As > we're now using Wheezy in OSSTest we can safely remove this overlay > file. > > Also add a note to reference #633127 above grub2 setup function, in case > someone trips over #633127. > > As we're now using Wheezy in production, update this file to Wheezy's > version and take care of Debian bug #690538 and GRUB bug #43420. When reference bugs it would be useful to include the bug title here so the reader doesn't have to go and look it up. #690538 relates to providing an option to remove the submenus. Please can the changelog explain why that is relevant to us. Did you fix it by removing/reverting the submenu support altogether, as opposed to e.g. importing the patch from Eric Fischer in the bug report? I don't see stuff which I'd expect if you had applied the patch. I think it would be worth spelling out in a bit more detail what the changes you've made to the baseline for each bug were. I suppose constructing overlay/etc/grub.d/20_linux_xen from a baseline unmodified version (checked in, not retrieved from the host) and a mini-patch-series (also checked in) on the fly is over complexifying things? Ian.