From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v3 07/11] mfi-common: create
	build-$arch-xsm job
Date: Wed, 10 Dec 2014 13:12:23 +0000
Message-ID: <1418217143.3505.39.camel@citrix.com>
References: <1413323416-21778-1-git-send-email-wei.liu2@citrix.com>
	<1413323416-21778-8-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1413323416-21778-8-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2014-10-14 at 22:50 +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  mfi-common |   23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/mfi-common b/mfi-common
> index 5c4f5d5..e772086 100644
> --- a/mfi-common
> +++ b/mfi-common
> @@ -41,6 +41,19 @@ branch_wants_rumpkernel_tests () {
>    esac
>  }
>  
> +xenbranch_wants_xsm_tests () {
> +    # Test XSM from 4.5 onwards
> +    case "$xenbranch" in
> +    xen-3.*-testing) echo "n";;
> +    xen-4.0-testing) echo "n";;
> +    xen-4.1-testing) echo "n";;
> +    xen-4.2-testing) echo "n";;
> +    xen-4.3-testing) echo "n";;
> +    xen-4.4-testing) echo "n";;
> +    *) echo "n y";

Did you mean just "y" here, or is something very subtle going on?

Oh I see, you run over the result of this as a list with for. Sneaky!

I think you should name it something like xenbranch_xsm_variants or
something else which doesn't make the reader expect it to return a
boolean.

Ian.