From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v3 11/11] mfi-common,
 make-flight: create XSM test jobs
Date: Wed, 10 Dec 2014 13:28:00 +0000
Message-ID: <1418218080.3505.50.camel@citrix.com>
References: <1413323416-21778-1-git-send-email-wei.liu2@citrix.com>
	<1413323416-21778-12-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1413323416-21778-12-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2014-10-14 at 22:50 +0100, Wei Liu wrote:
> +test_matrix_do_one () {
> +
> +  test_xsm=$(xenbranch_wants_xsm_tests)
> +
> +  # Basic PV Linux test with xl
> +  for xsm in $test_xsm ; do
> +    do_pv_linux_xl_test_one $xsm
> +  done

Perhaps push this down into do_pv_debian_tests which contains this loop
and calls down to do_pv_debian_test_one (similar to the
do_hvm_debian_tests setup).

Should we run an xsm test for libvirt too -- I don't see why not, in
that case do_pv_debian_tests would call do_pv_debian_test_one twice and
pass the toolstack as a parameter.

>  @@ -342,13 +361,13 @@ test_matrix_do_one () {
>      do_hvm_win7_x64_tests
>      do_hvm_rhel6_tests
>  
> -    do_hvm_debian_tests
> +    do_hvm_debian_tests $test_xsm

The parameter here should be quoted (and do_hvm_debian_tests should use
$1), but IMHO it would be better to have do_hvm_debian_tests call
xenbranch_wants_xsm_tests itself and loop on the result.

> diff --git a/mfi-common b/mfi-common
> index e772086..a81dfba 100644
> --- a/mfi-common
> +++ b/mfi-common
> @@ -267,9 +267,16 @@ job_create_test () {
>    local toolstack=$1; shift
>    local xenarch=$1; shift
>    local dom0arch=$1; shift
> +  local xsm=$1; shift

Can you detect enable_xsm=y in the remaining runvars (in $@ at this
point) and enable xsm based on that, instead of requiring an additional
parameter to be added to every caller?

	for rv in $@ ; do
            case $rv in
                enable_xsm=y) xsm_prefix="-xsm";;
            esac
        done

Is one way I'd try.

Ian.