From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST v3 04/11] overlay: update overlay/etc/grub.d/20_linux_xen Date: Wed, 10 Dec 2014 13:47:06 +0000 Message-ID: <1418219226.3505.53.camel@citrix.com> References: <1413323416-21778-1-git-send-email-wei.liu2@citrix.com> <1413323416-21778-5-git-send-email-wei.liu2@citrix.com> <1418216045.3505.28.camel@citrix.com> <20141210134150.GC19059@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141210134150.GC19059@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2014-12-10 at 13:41 +0000, Wei Liu wrote: > On Wed, Dec 10, 2014 at 12:54:05PM +0000, Ian Campbell wrote: > > #690538 relates to providing an option to remove the submenus. Please > > can the changelog explain why that is relevant to us. > > > > Because somebody else thought not making submenu optional is a bug. So > do I. I meant: why is this important to osstest? does using submenus break something? if so then what? if not then there is no reason to be diverging from the baseline. > > Did you fix it by removing/reverting the submenu support altogether, as > > opposed to e.g. importing the patch from Eric Fischer in the bug report? > > I don't see stuff which I'd expect if you had applied the patch. I think > > it would be worth spelling out in a bit more detail what the changes > > you've made to the baseline for each bug were. > > > > I fixed this by supplying a 20_linux_xen extracted from wheezy with > submenu generation removed (2 lines). This is how we dealt with other > grub bugs. I think precisely what you've changed from the baseline should be documented somewhere. Ian.