Re: [PATCH OSSTEST] Add basic PVH flights.

[Ian Campbell <Ian.Campbell@citrix.com>]

On Wed, 2014-12-10 at 13:56 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST] Add basic PVH flights."):
> > These are the usual PV debian flights with pvh=1 added to the
> > configuration file.
> > 
> > A job is created for each of Intel and AMD, although obviously AMD is
> > expected to fail at the moment.
> ...
> > Beyond that I've not tested this at all I fully expect even Intel to
> > fail in the first instance, due to issues such as lack of necessary
> > kernel options etc. I suggest to take this now and iterate on any
> > further changes.
> 
> That seems reasonable.
> 
> > For a xen-unstable flight this results in these runvars:
> > diff --git a/ts-debian-fixup b/ts-debian-fixup
> > index f001418..00477c5 100755
> > --- a/ts-debian-fixup
> > +++ b/ts-debian-fixup
> > @@ -118,6 +118,12 @@ sub otherfixupcfg () {
> ...
> > +    my $pvh = guest_var($gho,'pvh',undef);
> > +    if ($pvh) {
> > +	$cfg =~ s/^pvh.*//mg;
> 
> This should probably be
> 
>   +	$cfg =~ s/^pvh\b.*//mg;
> 
> unless you deliberately intend to strip out any other phv-related
> settings which xen-create-image might put there ?

Nope, your suggest is a good one.

Shall I resent or are you ok for me to do this change as I commit?