From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST] Add basic PVH flights. Date: Wed, 10 Dec 2014 13:58:37 +0000 Message-ID: <1418219917.3505.57.camel@citrix.com> References: <1418032544-28645-1-git-send-email-ian.campbell@citrix.com> <21640.20738.890057.47682@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21640.20738.890057.47682@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2014-12-10 at 13:56 +0000, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST] Add basic PVH flights."): > > These are the usual PV debian flights with pvh=1 added to the > > configuration file. > > > > A job is created for each of Intel and AMD, although obviously AMD is > > expected to fail at the moment. > ... > > Beyond that I've not tested this at all I fully expect even Intel to > > fail in the first instance, due to issues such as lack of necessary > > kernel options etc. I suggest to take this now and iterate on any > > further changes. > > That seems reasonable. > > > For a xen-unstable flight this results in these runvars: > > diff --git a/ts-debian-fixup b/ts-debian-fixup > > index f001418..00477c5 100755 > > --- a/ts-debian-fixup > > +++ b/ts-debian-fixup > > @@ -118,6 +118,12 @@ sub otherfixupcfg () { > ... > > + my $pvh = guest_var($gho,'pvh',undef); > > + if ($pvh) { > > + $cfg =~ s/^pvh.*//mg; > > This should probably be > > + $cfg =~ s/^pvh\b.*//mg; > > unless you deliberately intend to strip out any other phv-related > settings which xen-create-image might put there ? Nope, your suggest is a good one. Shall I resent or are you ok for me to do this change as I commit?