From: Joe Perches <joe@perches.com>
To: Luis de Bethencourt <luis@debethencourt.com>
Cc: m.chehab@samsung.com, jarod@wilsonet.com,
gregkh@linuxfoundation.org, mahfouz.saif.elyazal@gmail.com,
gulsah.1004@gmail.com, tuomas.tynkkynen@iki.fi,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines
Date: Wed, 10 Dec 2014 16:01:04 -0800 [thread overview]
Message-ID: <1418256064.18092.26.camel@perches.com> (raw)
In-Reply-To: <20141210235741.GA10195@biggie>
On Wed, 2014-12-10 at 23:57 +0000, Luis de Bethencourt wrote:
> On Wed, Dec 10, 2014 at 03:39:09PM -0800, Joe Perches wrote:
> > On Wed, 2014-12-10 at 22:33 +0000, Luis de Bethencourt wrote:
> > > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
[]
> > > + dev_err(tx->ir->l.dev,
> > > + "unsupported code set file version (%u, expected 1) -- please upgrade to a newer driver",
> > > + version);
> >
> > Unrelated but this one should have a '\n' termination
> > at the end of the format.
> I can add that change, no problem. As part of this patch or a third one?
Up to you.
next prev parent reply other threads:[~2014-12-11 0:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 22:33 [PATCH v4 1/2] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines Luis de Bethencourt
2014-12-10 23:39 ` Joe Perches
2014-12-10 23:57 ` Luis de Bethencourt
2014-12-11 0:01 ` Joe Perches [this message]
2014-12-11 0:20 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418256064.18092.26.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gulsah.1004@gmail.com \
--cc=jarod@wilsonet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=m.chehab@samsung.com \
--cc=mahfouz.saif.elyazal@gmail.com \
--cc=tuomas.tynkkynen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.