From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY
Date: Wed, 10 Dec 2014 23:06:08 -0800 [thread overview]
Message-ID: <1418281568.18092.34.camel@perches.com> (raw)
In-Reply-To: <54893F26.5050304@rock-chips.com>
On Thu, 2014-12-11 at 14:52 +0800, Yunzhi Li wrote:
> On 2014/12/11 14:37, Joe Perches wrote:
> > On Thu, 2014-12-11 at 11:57 +0530, Kishon Vijay Abraham I wrote:
[]
> >> So If I have to write something on bit 0, I have to set bit 16.
> >> If I have to write something on bit 1, I have to set bit 17.
> >> If I have to write something on bit 2, I have to set bit 18.
> >> and so on.
> > To me it'd look better to use another << rather than a plus
> Like (BIT(13) << 16)? It looks strange, or could I just use ((1 << 13)
> << 16) to describe this bit ?
Up to you. To me, the BIT(x+y) seems odd.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Yunzhi Li <lyz-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY
Date: Wed, 10 Dec 2014 23:06:08 -0800 [thread overview]
Message-ID: <1418281568.18092.34.camel@perches.com> (raw)
In-Reply-To: <54893F26.5050304-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
On Thu, 2014-12-11 at 14:52 +0800, Yunzhi Li wrote:
> On 2014/12/11 14:37, Joe Perches wrote:
> > On Thu, 2014-12-11 at 11:57 +0530, Kishon Vijay Abraham I wrote:
[]
> >> So If I have to write something on bit 0, I have to set bit 16.
> >> If I have to write something on bit 1, I have to set bit 17.
> >> If I have to write something on bit 2, I have to set bit 18.
> >> and so on.
> > To me it'd look better to use another << rather than a plus
> Like (BIT(13) << 16)? It looks strange, or could I just use ((1 << 13)
> << 16) to describe this bit ?
Up to you. To me, the BIT(x+y) seems odd.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Yunzhi Li <lyz@rock-chips.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
heiko@sntech.de, jwerner@chromium.org, dianders@chromium.org,
olof@lixom.net, huangtao@rock-chips.com, zyw@rock-chips.com,
cf@rock-chips.com, linux-rockchip@lists.infradead.org,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY
Date: Wed, 10 Dec 2014 23:06:08 -0800 [thread overview]
Message-ID: <1418281568.18092.34.camel@perches.com> (raw)
In-Reply-To: <54893F26.5050304@rock-chips.com>
On Thu, 2014-12-11 at 14:52 +0800, Yunzhi Li wrote:
> On 2014/12/11 14:37, Joe Perches wrote:
> > On Thu, 2014-12-11 at 11:57 +0530, Kishon Vijay Abraham I wrote:
[]
> >> So If I have to write something on bit 0, I have to set bit 16.
> >> If I have to write something on bit 1, I have to set bit 17.
> >> If I have to write something on bit 2, I have to set bit 18.
> >> and so on.
> > To me it'd look better to use another << rather than a plus
> Like (BIT(13) << 16)? It looks strange, or could I just use ((1 << 13)
> << 16) to describe this bit ?
Up to you. To me, the BIT(x+y) seems odd.
next prev parent reply other threads:[~2014-12-11 7:06 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 10:46 [PATCH v5 0/5] Patches to add support for Rockchip usb PHYs Yunzhi Li
2014-12-10 10:46 ` Yunzhi Li
2014-12-10 10:46 ` Yunzhi Li
2014-12-10 10:46 ` [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY Yunzhi Li
2014-12-10 10:46 ` Yunzhi Li
2014-12-11 6:02 ` Kishon Vijay Abraham I
2014-12-11 6:02 ` Kishon Vijay Abraham I
2014-12-11 6:02 ` Kishon Vijay Abraham I
2014-12-11 6:12 ` Joe Perches
2014-12-11 6:12 ` Joe Perches
2014-12-11 6:27 ` Kishon Vijay Abraham I
2014-12-11 6:27 ` Kishon Vijay Abraham I
2014-12-11 6:27 ` Kishon Vijay Abraham I
2014-12-11 6:37 ` Joe Perches
2014-12-11 6:37 ` Joe Perches
2014-12-11 6:37 ` Joe Perches
2014-12-11 6:52 ` Yunzhi Li
2014-12-11 6:52 ` Yunzhi Li
2014-12-11 6:52 ` Yunzhi Li
2014-12-11 7:06 ` Joe Perches [this message]
2014-12-11 7:06 ` Joe Perches
2014-12-11 7:06 ` Joe Perches
2014-12-11 7:16 ` Chris Zhong
2014-12-11 7:16 ` Chris Zhong
2014-12-11 7:16 ` Chris Zhong
2014-12-11 7:44 ` Yunzhi Li
2014-12-11 7:44 ` Yunzhi Li
2014-12-11 7:44 ` Yunzhi Li
2014-12-11 8:36 ` Kishon Vijay Abraham I
2014-12-11 8:36 ` Kishon Vijay Abraham I
2014-12-11 8:36 ` Kishon Vijay Abraham I
[not found] ` <1418208371-18851-1-git-send-email-lyz-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-10 10:46 ` [PATCH v5 2/5] Documentation: bindings: add dt documentation for Rockchip usb PHY Yunzhi Li
2014-12-10 10:46 ` Yunzhi Li
2014-12-10 10:46 ` [PATCH v5 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver Yunzhi Li
2014-12-10 10:46 ` [PATCH v5 4/5] ARM: dts: rockchip: add rk3288 usb PHY Yunzhi Li
2014-12-10 10:46 ` Yunzhi Li
2014-12-10 10:46 ` Yunzhi Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418281568.18092.34.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.