All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jes.Sorensen@redhat.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] wireless: mac80211: Avoid using uninitialized stack data
Date: Thu, 11 Dec 2014 09:14:48 +0100	[thread overview]
Message-ID: <1418285688.1947.0.camel@sipsolutions.net> (raw)
In-Reply-To: <1418238847-3332-2-git-send-email-Jes.Sorensen@redhat.com>

On Wed, 2014-12-10 at 14:14 -0500, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
> 
> Avoid case where we would access uninitialized stack data if a driver
> advertises HT support without 40MHz channel support.

>  		ret = IEEE80211_STA_DISABLE_40MHZ;
> +		vht_chandef = *chandef;

I think we can and should disable VHT in this case, since VHT requires
40 and 80 MHz support.

johannes


  reply	other threads:[~2014-12-11  8:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10 19:14 [PATCH 0/1] mac80211: Avoid accessing uninitialized stack data Jes.Sorensen
2014-12-10 19:14 ` [PATCH 1/1] wireless: mac80211: Avoid using " Jes.Sorensen
2014-12-11  8:14   ` Johannes Berg [this message]
2014-12-12 11:03   ` Johannes Berg
2014-12-12 14:02     ` Jes Sorensen
  -- strict thread matches above, loose matches on Subject: below --
2014-12-11 16:37 [PATCH v2 0/1] mac80211: Avoid accessing " Jes.Sorensen
2014-12-11 16:37 ` [PATCH 1/1] wireless: mac80211: Avoid using " Jes.Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418285688.1947.0.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Jes.Sorensen@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.