From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 03/27] Guest setup: allow the amount of RAM
 to be a runvar
Date: Thu, 11 Dec 2014 13:57:59 +0100
Message-ID: <1418302679.31647.85.camel@Abyss.station>
References: <20141210180651.26400.13356.stgit@Abyss.station>
	<20141210180918.26400.69599.stgit@Abyss.station>
	<20141211120553.GG21659@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4866485337314963961=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20141211120553.GG21659@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============4866485337314963961==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-iYrXjAvKc+zTbz1TQIBU"

--=-iYrXjAvKc+zTbz1TQIBU
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2014-12-11 at 12:05 +0000, Wei Liu wrote:
> On Wed, Dec 10, 2014 at 07:09:18PM +0100, Dario Faggioli wrote:
> > diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> > index a3b6936..cdff8d5 100644
> > --- a/Osstest/TestSupport.pm
> > +++ b/Osstest/TestSupport.pm
> > @@ -1460,11 +1460,12 @@ sub prepareguest_part_xencfg ($$$$$) {
> >      my ($ho, $gho, $ram_mb, $xopts, $cfgrest) =3D @_;
> >      my $onreboot=3D $xopts->{OnReboot} || 'restart';
> >      my $vcpus=3D guest_var($gho, 'vcpus', $xopts->{DefVcpus} || 2);
> > +    my $memory=3D guest_var($gho, 'memory', $xopts->{DefMem} || $ram_m=
b);
> >      my $xoptcfg=3D $xopts->{ExtraConfig};
> >      $xoptcfg=3D'' unless defined $xoptcfg;
> >      my $xencfg=3D <<END;
> >  name        =3D '$gho->{Name}'
> > -memory =3D ${ram_mb}
> > +memory =3D ${memory}
>=20
> You made ram_mb redundant.
>
Did I? My idea was to use it as default, if the runvar is not defined...
That is what I though this line does (and I'm quite sure I tested it
actually does that):

my $memory=3D guest_var($gho, 'memory', $xopts->{DefMem} || $ram_mb);

But, perhaps, I'm not getting what you mean by "redundant"...

>  And this seems to be deep in the call chain
> which has subtle knock on effect.
>=20
Sorry, I don't get what you mean here.

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-iYrXjAvKc+zTbz1TQIBU
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlSJlNcACgkQk4XaBE3IOsRHYwCfeHe/fvhpaXWALlFD/LHvfcgD
xvgAn2zNe/19EM13aW0fYGXhsKcxT83G
=wAnm
-----END PGP SIGNATURE-----

--=-iYrXjAvKc+zTbz1TQIBU--


--===============4866485337314963961==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4866485337314963961==--