From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v2 1/6] ASoC: dwc: Remove unnecessary debug messages and tests Date: Fri, 12 Dec 2014 01:31:11 -0800 Message-ID: <1418376671.18092.40.camel@perches.com> References: <97f65b6037b9ac676f6ca7717a230a68cbe81fd1.1418372910.git.Andrew.Jackson@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <97f65b6037b9ac676f6ca7717a230a68cbe81fd1.1418372910.git.Andrew.Jackson@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Jackson Cc: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Rajeev Kumar , Liviu Dudau , Lars-Peter Clausen , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Fri, 2014-12-12 at 09:25 +0000, Andrew Jackson wrote: > The devm_XXX allocation functions print a message on failure, > so additional messages are not required. [] > diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c [] > @@ -345,26 +345,17 @@ static int dw_i2s_probe(struct platform_device *pdev) > } > > dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL); > - if (!dw_i2s_dai) { > - dev_err(&pdev->dev, "mem allocation failed for dai driver\n"); > + if (!dw_i2s_dai) > return -ENOMEM; > - } ok. > dw_i2s_dai->ops = &dw_i2s_dai_ops; > dw_i2s_dai->suspend = dw_i2s_suspend; > dw_i2s_dai->resume = dw_i2s_resume; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(&pdev->dev, "no i2s resource defined\n"); > - return -ENODEV; > - } > - Why delete this? > dev->i2s_base = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(dev->i2s_base)) { > - dev_err(&pdev->dev, "ioremap fail for i2s_region\n"); > + if (IS_ERR(dev->i2s_base)) > return PTR_ERR(dev->i2s_base); > - } or this? From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Fri, 12 Dec 2014 01:31:11 -0800 Subject: [PATCH v2 1/6] ASoC: dwc: Remove unnecessary debug messages and tests In-Reply-To: <97f65b6037b9ac676f6ca7717a230a68cbe81fd1.1418372910.git.Andrew.Jackson@arm.com> References: <97f65b6037b9ac676f6ca7717a230a68cbe81fd1.1418372910.git.Andrew.Jackson@arm.com> Message-ID: <1418376671.18092.40.camel@perches.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2014-12-12 at 09:25 +0000, Andrew Jackson wrote: > The devm_XXX allocation functions print a message on failure, > so additional messages are not required. [] > diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c [] > @@ -345,26 +345,17 @@ static int dw_i2s_probe(struct platform_device *pdev) > } > > dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL); > - if (!dw_i2s_dai) { > - dev_err(&pdev->dev, "mem allocation failed for dai driver\n"); > + if (!dw_i2s_dai) > return -ENOMEM; > - } ok. > dw_i2s_dai->ops = &dw_i2s_dai_ops; > dw_i2s_dai->suspend = dw_i2s_suspend; > dw_i2s_dai->resume = dw_i2s_resume; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(&pdev->dev, "no i2s resource defined\n"); > - return -ENODEV; > - } > - Why delete this? > dev->i2s_base = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(dev->i2s_base)) { > - dev_err(&pdev->dev, "ioremap fail for i2s_region\n"); > + if (IS_ERR(dev->i2s_base)) > return PTR_ERR(dev->i2s_base); > - } or this?