From: Tomasz Figa <t.figa@samsung.com>
To: balbi@ti.com
Cc: linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org,
kyungmin.park@samsung.com, kgene.kim@samsung.com,
p.paneri@samsung.com, gautam.vivek@samsung.com,
m.szyprowski@samsung.com
Subject: Re: [PATCH 3/6] usb: phy: samsung: Consolidate reference clock rate handling
Date: Wed, 27 Mar 2013 14:26:08 +0100 [thread overview]
Message-ID: <1418529.52pdDLWkRZ@amdc1227> (raw)
In-Reply-To: <20130327131958.GH4626@arwen.pp.htv.fi>
Hi Felipe,
On Wednesday 27 of March 2013 15:19:58 Felipe Balbi wrote:
> Hi,
>
> On Tue, Mar 26, 2013 at 03:53:12PM +0100, Tomasz Figa wrote:
> > @@ -307,6 +310,7 @@ static int samsung_usb3phy_remove(struct
> > platform_device *pdev)>
> > static struct samsung_usbphy_drvdata usb3phy_exynos5 = {
> >
> > .cpu_type = TYPE_EXYNOS5250,
> > .devphy_en_mask = EXYNOS_USBPHY_ENABLE,
> >
> > + .rate_to_clksel = samsung_usbphy_rate_to_clksel_4x12,
>
> why isn't this just a clk_get_rate() ???
As the name suggests, this is a function to get appropriate CLKSEL value to
write into PHYCLK register for reference clock rate on particular platform
(clk_get_rate is used inside to get the rate).
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Kernel and System Framework
next prev parent reply other threads:[~2013-03-27 13:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 14:53 [PATCH 0/6] Samsung USB PHY SoC support cleanup Tomasz Figa
2013-03-26 14:53 ` [PATCH 1/6] usb: phy: samsung: Select common driver part implicitly Tomasz Figa
2013-03-26 14:53 ` [PATCH 2/6] usb: phy: samsung: Use clk_get to get reference clock Tomasz Figa
[not found] ` <1364309595-16102-1-git-send-email-t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-03-26 14:53 ` [PATCH 3/6] usb: phy: samsung: Consolidate reference clock rate handling Tomasz Figa
2013-03-27 13:19 ` Felipe Balbi
2013-03-27 13:26 ` Tomasz Figa [this message]
2013-03-27 13:31 ` Felipe Balbi
[not found] ` <20130327133149.GI4626-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-03-27 13:39 ` Tomasz Figa
2013-03-27 13:43 ` Felipe Balbi
2013-03-26 14:53 ` [PATCH 4/6] usb: phy: samsung: Pass set_isolation callback through driver data Tomasz Figa
2013-03-26 14:53 ` [PATCH 5/6] usb: phy: samsung: Pass enable/disable callbacks " Tomasz Figa
2013-03-26 14:53 ` [PATCH 6/6] usb: phy: samsung: Add support for USB 2.0 PHY on Exynos 4x12 Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418529.52pdDLWkRZ@amdc1227 \
--to=t.figa@samsung.com \
--cc=balbi@ti.com \
--cc=gautam.vivek@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=p.paneri@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.