From: Joe Perches <joe@perches.com>
To: Eduardo Barretto <edusbarretto@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue
Date: Sun, 14 Dec 2014 18:11:30 -0800 [thread overview]
Message-ID: <1418609490.2674.7.camel@perches.com> (raw)
In-Reply-To: <1418608974-22509-1-git-send-email-edusbarretto@gmail.com>
On Mon, 2014-12-15 at 00:02 -0200, Eduardo Barretto wrote:
> Fixed a coding style issue
[]
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
[]
> @@ -4123,12 +4123,11 @@ static int hfa384x_isgood_pdrcode(u16 pdrcode)
> pr_debug("Encountered unknown PDR#=0x%04x, assuming it's ok.\n",
> pdrcode);
> return 1;
> - } else {
> - /* bad code */
> - pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
> - pdrcode);
> - return 0;
> }
> + /* bad code */
> + pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
> + pdrcode);
> + return 0;
> }
> return 0; /* avoid compiler warnings */
> }
While this patch isn't necessary, if any change is
done, it might better to not have two consecutive
return 0; uses.
next prev parent reply other threads:[~2014-12-15 2:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 2:02 [PATCH] Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue Eduardo Barretto
2014-12-15 2:11 ` Joe Perches [this message]
2014-12-15 20:53 ` Eduardo Barretto
2014-12-15 21:28 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418609490.2674.7.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=edusbarretto@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.