Re: [PATCH] tools: libxl: link libxlu against libxl.

[Ian Campbell <Ian.Campbell@citrix.com>]

On Mon, 2014-08-04 at 10:58 +0100, Ian Campbell wrote:

Ping again. This issue has resurfaced in the Debian packaging of the 4.5
rcs. I think we should fix this for 4.5, the risks are minimal.

> It uses libxl_defbool_set and must therefore be linked against the
> right library.
> 
> Spotted by dpkg-shlibdeps and pointed out by Bastian Blank:
> 
> dpkg-shlibdeps: warning: symbol libxl_defbool_set used by debian/libxen-4.4/usr/lib/libxlutil-4.4.so found in none of the libraries
> 
> This required switching the make rule from $^ to an explicit
> LIBXLU_OBJS since the former now includes libxenlight.so.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Bastian Blank <waldi@debian.org>
> ---
>  tools/libxl/Makefile |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index bd0db3b..e61048d 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -35,7 +35,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
>  LIBXL_LIBS += $(PTHREAD_LIBS)
>  LIBXL_LIBS += $(LIBXL_LIBS-y)
>  
> -LIBXLU_LIBS =
> +LIBXLU_LIBS = libxenlight.so
>  
>  LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o
>  ifeq ($(LIBXL_BLKTAP),y)
> @@ -213,8 +213,8 @@ libxlutil.so: libxlutil.so.$(XLUMAJOR)
>  libxlutil.so.$(XLUMAJOR): libxlutil.so.$(XLUMAJOR).$(XLUMINOR)
>  	$(SYMLINK_SHLIB) $< $@
>  
> -libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS)
> -	$(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
> +libxlutil.so.$(XLUMAJOR).$(XLUMINOR): $(LIBXLU_OBJS) libxenlight.so
> +	$(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxlutil.so.$(XLUMAJOR) $(SHLIB_LDFLAGS) -o $@ $(LIBXLU_OBJS) $(LIBXLU_LIBS) $(APPEND_LDFLAGS)
>  
>  libxlutil.a: $(LIBXLU_OBJS)
>  	$(AR) rcs libxlutil.a $^