From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.5 v2] xl: print message to stdout when (!debug && dryrun) Date: Mon, 15 Dec 2014 11:06:43 +0000 Message-ID: <1418641603.16425.89.camel@citrix.com> References: <1418640984-21639-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1418640984-21639-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: m.a.young@durham.ac.uk, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2014-12-15 at 10:56 +0000, Wei Liu wrote: > In commit d36a3734a ("xl: fix migration failure with xl migrate > --debug"), message is printed to stderr for both debug mode > and dryrun mode. That caused rdname() in xendomains fails to parse > domain name since it's expecting input from xl's stdout. > > So this patch separates those two cases. If xl is running in debug mode, > then message is printed to stderr; if xl is running in dryrun mode and > debug is not enabled, message is printed to stdout. This will fix > xendomains and other scripts that use "xl create --dryrun", as well as > not re-introducing the old bug fixed in d36a3734a. > > Reported-by: Mark Pryor > Signed-off-by: Wei Liu > Cc: M A Young > Cc: Ian Campbell > Release-Acked-by: Konrad Wilk Acked-by: Ian Campbell