Re: [PATCH 0/3] wic: glob support & minor fixes

[Tom Zanussi <tom.zanussi@linux.intel.com>]

On Wed, 2014-12-10 at 12:45 +0100, Maciej Borzecki wrote:
> This patch series adds changes that enable globbing in IMAGE_BOOT_FILES.
> Effectivey this makes use of with with Raspberry Pi a tad easier, when a
> lengthy list of boot files can be replaced with just one entry. A related
> change to meta-raspberrypi will be sent to the Yocto mailing list.
> 

Looks ok to me, and I tried it out with your raspberrypi layer changes
which generated the image (I didn't try any other image types to check
against regressions there, though nothing in here looks like it would
touch anything related to the other source plugins, so I'm not worried -
in the next milestone I hope to have some automated wic testing going to
make checking easy).

I do think, though, that we need to have the documentation for this in
the tool itself.  As it stands, the IMAGE_BOOT_FILES variable is
documented in the manual, but even then, there's no context that ties it
to the bootimg-partition plugin.  I think we need to add a mechanism so
that help text can be added to each plugin, which would be automatically
picked up and merged probably into a plugin-specific 'help plugins'
section in the tool.

The other thing I noticed, which has nothing to do with this patchset,
but along the same lines, is that the plugin machinery does find the
sdimage-raspberrypi.wks file to generate the image, as expected, but it
doesn't show up in 'wic list source-plugins', as you'd expect.

Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>

> Maciej Borzecki (3):
>   wic: IMAGE_BOOT_FILES format checks in bootimg-partition source
>   wic: add globbing support in IMAGE_BOOT_FILES entries
>   ref-manual: update IMAGE_BOOT_FILES entry
> 
>  documentation/ref-manual/ref-variables.xml         | 37 +++++++++++++++----
>  .../lib/wic/plugins/source/bootimg-partition.py    | 43 +++++++++++++++++-----
>  2 files changed, 64 insertions(+), 16 deletions(-)
> 
> -- 
> 1.9.3
>