From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v2 for-4.5 1/3] python/xc: Fix multiple
 issues in pyflask_context_to_sid()
Date: Tue, 16 Dec 2014 17:16:25 +0000
Message-ID: <1418750185.20265.0.camel@citrix.com>
References: <20141209162048.GB9585@laptop.dumpdata.com>
	<1418143402-29674-1-git-send-email-andrew.cooper3@citrix.com>
	<20141210171345.GM4268@laptop.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20141210171345.GM4268@laptop.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Xen Coverity Team <coverity@xen.org>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-12-10 at 12:13 -0500, Konrad Rzeszutek Wilk wrote:
> On Tue, Dec 09, 2014 at 04:43:22PM +0000, Andrew Cooper wrote:
> > The error handling from a failed memory allocation should return
> > PyErr_SetFromErrno(xc_error_obj); rather than simply calling it and continuing
> > to the memcpy() below, with the dest pointer being NULL.
> > 
> > Coverity also complains about passing a non-NUL terminated string to
> > xc_flask_context_to_sid().  xc_flask_context_to_sid() doesn't actually take a
> > NUL terminated string, but it does take a char* which, in context, used to be
> > a string, which is why Coverity complains.
> > 
> > One solution would be to use strdup(ctx) which is simpler than a
> > strlen()/malloc()/memcpy() combo, which would result in a NUL-terminated
> > string being used with xc_flask_context_to_sid().
> > 
> > However, ctx is strictly an input to the hypercall and is not mutated along
> > the way.  Both these issues can be fixed, and the error logic simplified, by
> > not duplicating ctx in the first place.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Coverity-IDs: 1055305 1055721
> > Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
> > CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > CC: Wei Liu <wei.liu2@citrix.com>
> > CC: Xen Coverity Team <coverity@xen.org>
> > 
> > ---
> > v2: Expand the commit message.  No code change
> 
> Thank you.
> 
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 

Applied.